From owner-p4-projects@FreeBSD.ORG  Sun Mar 13 23:19:59 2005
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 15ABF16A4D0; Sun, 13 Mar 2005 23:19:59 +0000 (GMT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id CB90616A4CE; Sun, 13 Mar 2005 23:19:58 +0000 (GMT)
Received: from gw-kit.locore.ca (gw-kit.locore.ca [67.43.130.39])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 6BACD43D1D; Sun, 13 Mar 2005 23:19:58 +0000 (GMT)
	(envelope-from jake@locore.ca)
Received: from [10.0.0.3] (ws.locore.ca [10.0.0.3])
	by gw-kit.locore.ca (Postfix) with ESMTP id 944041BAC7B;
	Sun, 13 Mar 2005 18:19:57 -0500 (EST)
Message-ID: <4234CA9D.9080108@locore.ca>
Date: Sun, 13 Mar 2005 18:19:57 -0500
From: Jake Burkholder <jake@locore.ca>
User-Agent: Mozilla Thunderbird 1.0 (X11/20050213)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: John Baldwin <jhb@FreeBSD.org>
References: <200503032211.j23MBlia013010@repoman.freebsd.org>
In-Reply-To: <200503032211.j23MBlia013010@repoman.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 72454 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Mar 2005 23:19:59 -0000

John Baldwin wrote:

>http://perforce.freebsd.org/chv.cgi?CH=72454
>
>Change 72454 by jhb@jhb_slimer on 2005/03/03 22:11:16
>
>	Clobber all memory for atomic ops with an acquire barrier.
>	
>	Suggested by:	   alc
>
>Affected files ...
>
>.. //depot/projects/smpng/sys/sparc64/include/atomic.h#7 edit
>
>Differences ...
>
>==== //depot/projects/smpng/sys/sparc64/include/atomic.h#7 (text+ko) ====
>
>@@ -90,6 +90,7 @@
> 	itype(sz) v;							\
> 	v = atomic_cas(p, e, s, sz);					\
> 	membar(LoadLoad | LoadStore);					\
>+	__asm __volatile("" : : : "memory");				\
> 	v;								\
> })
> 
>@@ -115,6 +116,7 @@
> 	itype(sz) t;							\
> 	t = atomic_op(p, op, v, sz);					\
> 	membar(LoadLoad | LoadStore);					\
>+	__asm __volatile("" : : : "memory");				\
> 	t;								\
> })
> 
>@@ -132,6 +134,7 @@
> 	itype(sz) v;							\
> 	v = atomic_load(p, sz);						\
> 	membar(LoadLoad | LoadStore);					\
>+	__asm __volatile("" : : : "memory");				\
> 	v;								\
> })
> 
>
>  
>
membar already has a memory clobber fwiw.

Jake