From nobody Sun Mar 3 10:28:51 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TndN63K7cz5CVXh; Sun, 3 Mar 2024 10:28:54 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TndN61FpJz4dDr; Sun, 3 Mar 2024 10:28:54 +0000 (UTC) (envelope-from mat@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1709461734; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Amxkpz24FyjgL2+qhafViJLHPiOuyucuRAXrkBmu7bc=; b=HzRRpPqyrLR9vpmp7NTRpcY6YEs3sXZYUhBgymYnWoCS1+Oy6LGdKkq8m6UnsTR5D2Y8RT k7Lq0kKP0ZGzzIgrtiysaNv6L/FULAHPYWuxUkxSl8ySKNHWMqN/jTVjbWMIZOSRoDO3cq fUwgWXw8ftrmw8LKoc5AsGtYSRnhM24/UHz9bDNlu31bQ3mtXaefDrAaNDDlEEz+Fsf7T5 x+6hDMjZkCiSuSSbBl7k9OS4UH95AzDqUnoH5xTQrKP7FO3f3Tu91nGZrStfM5gY9j0kxr o9HNMxPVG6FhlGaX8lkDfUB48Hj4u134u+1NQ/x9VP0N9+iZ4/QV3m1QH3TBZA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1709461734; a=rsa-sha256; cv=none; b=hiZMgthktIPwrWiBSI5XOJY0xv7E5jjNvzM4VZJNhcawnRrcs1SaSzNQ1pUHh9lkh93pRU 8+kxln8OCOToqT+o7KFg9Qhg6VB5vL8/ZDpLlIhuqfMX/fEbwr9reTxZmJMeR0q94p4k+R pknVt/Inz0yYjaAR4+l4aPyUQjJGcYlC4b972o4K9jcfrryb9luOn91tQbBFGm0bRwnd/g LEyoK7WQ6peX9T9lByxCiZ+zL2BeHoAlTNZRiAFKqKmmEGm3TI9AnYhbGeR3aaLZxJ7JK3 OPzzLGWJIeJKL9fltK+BJMGU6ocRJSwKHb1gFpiPJjIHoC9q3Z7NRzV/Ru9Yaw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1709461734; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Amxkpz24FyjgL2+qhafViJLHPiOuyucuRAXrkBmu7bc=; b=vWpeWD28vgw3F5nG5vXYpzEH6V2PpsvzNZYwCt9qattHX6/+8DMNQlO2NjgHLzCDUpJH3V rJrC2srdFdOeY5JuztmCkKMCtF9t0ca/H9K9BSA8PcBYQqv1v77Q/r+Nn5dCJvAHjg6I7A 8SN3auSpNoCBAJIMuJtruYXYqIZRK+MrrJAQWEJFayc7dhwhdkw4NAGqPE3hum+DP3k3gT PLkUmIwk65eBBGcNaervEDG1yB9Y0hkp3qZs8RI+k3akWxzNP0i65ZkItulX8ROKo6upVI 5wopGVgbLc3GHEsW7b7P4o8stXl0Gmx8gcrNM9YwYwMgizjg5dAlKqGL7QyN1w== Received: from relay.mat.cc (cow.mat.cc [79.143.244.49]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "cow.mat.cc", Issuer "R3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4TndN605cXz13px; Sun, 3 Mar 2024 10:28:53 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from aching.in.mat.cc (unknown [IPv6:2a01:e0a:836:f670:c19d:9574:508c:2978]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by relay.mat.cc (Postfix) with ESMTPSA id 3D183209F9; Sun, 3 Mar 2024 11:28:52 +0100 (CET) Date: Sun, 3 Mar 2024 11:28:51 +0100 From: Mathieu Arnold To: Gleb Popov Cc: Thomas Zander , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: a995b8b0ab54 - main - multimedia/{mplayer/mencoder}: Move DEBUG from OPTIONS to WITH_DEBUG Message-ID: References: <202403021836.422Ia4o2021754@gitrepo.freebsd.org> <5l6vknhs4q4ljz5fe52ksdofxsnfaautnuetnqeb5cbj5c2uay@qbtuvdsmy7fk> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5r3h42gm5ya4dolv" Content-Disposition: inline In-Reply-To: --5r3h42gm5ya4dolv Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 03, 2024 at 12:01:41PM +0300, Gleb Popov wrote: > On Sun, Mar 3, 2024 at 11:56=E2=80=AFAM Mathieu Arnold = wrote: > > > > There is no trend, it's a rule, debug must be handled with WITH_DEBUG > > knob, and not via an option. > > If there is an option that enable some sort of debugging or verbose > > thing but that is not supposed to add debugging symbols, then it should > > not be called DEBUG. >=20 > In that case we need a qa check that prevents adding DEBUG option and > then we can also introduce a generic DEBUG_VAR helper to get rid of > ifdefs? What do you mean DEBUG_VAR ? --=20 Mathieu Arnold --5r3h42gm5ya4dolv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmXkUOJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb6S+gv9HTHc74s6H+ZxVBlDSsEQx2J5i1VZXEy0PA9nIctuIqn3Jh9URMXr7JGQ AdAAwR1Aem3qYzOqqmVXZlCMxsGTXuvUU9pCVa4iIS1RDaPRUMZzYsJfS1M7G6We HMtc4lW0bg0qzsUYy8pivMN0ka30z2FuLfcgPo3EyEJ3Xr6nuzyJ/Mq55mhED8ZY x8uTTZCNx7JxAa6qF253iP+eYrW+RSYEW0hEcfqvrJRChwV5cDIM/2zNry/k+esO Pyox+W1TFy4l8tGJBfP/yqYTpJ1J2NPBwad4orLwvZImOcQExfsB4uG1+LFc+Ck5 ifdcDGsk4hFPL2vWuA7OBp+MKJQx2gbBiBbm37WbpbOkEUYnf2y6SqqDqQK2p/fG NLb+nR9vI/HzT9RukeG6t7Fzlym7MUM5/tfwvtAG2lekutklnxRj5JU18KJR7b8Q Xs439ZnnFz17KT6V8bi5OYIkvBK70VMqfdYMnnK8HF8I6guoqOxa9x40kH28FjPf XHwTcyYx =A4W8 -----END PGP SIGNATURE----- --5r3h42gm5ya4dolv--