Date: Sat, 14 Sep 2019 23:25:37 +0000 From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: [Bug 240585] audio/pulseaudio: Update to 13.0 Message-ID: <bug-240585-6497@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240585 Bug ID: 240585 Summary: audio/pulseaudio: Update to 13.0 Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: gnome@FreeBSD.org Reporter: lightside@gmx.com CC: gnome@FreeBSD.org, jbeich@FreeBSD.org, kwm@FreeBSD.org Assignee: gnome@FreeBSD.org Flags: maintainer-feedback?(gnome@FreeBSD.org) Attachment #207491 maintainer-approval?(gnome@FreeBSD.org) Flags: CC: gnome@FreeBSD.org Created attachment 207491 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D207491&action= =3Dedit Proposed patch (since 507372 revision) Patch to update audio/pulseaudio port from 12.2 to 13.0 version. Look following links for changes: https://www.freedesktop.org/wiki/Software/PulseAudio/Notes/13.0/ https://gitlab.freedesktop.org/pulseaudio/pulseaudio/compare/v12.2...v13.0 ABI: https://abi-laboratory.pro/tracker/timeline/pulseaudio/ - Remove intltool from USE_GNOME variable [1] - Add src/utils/pa-info to SHEBANG_FILES variable - Add fix for src/pulsecore/atomic.h [2] - Add fix for src/tests/atomic-test.c [3] - Update pkg-plist For reference: 1. Use upstream gettext instead intltool https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/57e3ccaf51f714e= ec8ca29005c3cc4fde456e84e 2. Fixes following error, when using WEBRTC_AEC port's option and Clang compiler: -8<-- In file included from modules/echo-cancel/webrtc.cc:31: In file included from ./pulsecore/modargs.h:29: In file included from ./pulsecore/resampler.h:25: In file included from ./pulsecore/memblock.h:31: ./pulsecore/atomic.h:120:33: error: cannot initialize a parameter of type 'volatile unsigned long' with an lvalue of type 'void *' __atomic_store_n(&a->value, p, __ATOMIC_SEQ_CST); ^ -->8- The GCC compiler doesn't report about this (and probably not affected). This is because of following commit: atomic: fix load and store for armv7 and higher https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/d4ff4adce2808c3= 1898b4b7d2f60825effb61484 Alternative approach is to define "pulseaudio_cv_atomic_store_n" variable: CONFIGURE_ENV+=3D pulseaudio_cv_atomic_store_n=3D"" The "uintptr_t" type was used because of: https://github.com/freebsd/freebsd/blob/e100f32e6e1cd39a01dea1c5e99ba63fe0a= 2b2e8/contrib/compiler-rt/lib/builtins/emutls.c#L250 https://github.com/freebsd/freebsd/blob/e100f32e6e1cd39a01dea1c5e99ba63fe0a= 2b2e8/contrib/compiler-rt/lib/builtins/emutls.c#L320-L327 "Integer type capable of holding a value converted from a void pointer and = then be converted back to that type with a value that compares equal to the orig= inal pointer." http://www.cplusplus.com/reference/cstdint/ 3. Fixes following error (or similar errors): -8<-- tests/atomic-test.c:58:4: error: unknown type name 'cpu_set_t'; did you mean 'cpusetid_t'? cpu_set_t cpuset; ^~~~~~~~~ cpusetid_t -->8- Related to [2], but possible to use "--disable-default-build-tests" configu= re option instead: CONFIGURE_ARGS+=3D --disable-default-build-tests -8<-- % ./configure --help | grep -h1 disable-default-build-tests | tail -2 --disable-default-build-tests Build test programs only during make check -->8- --=20 You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-240585-6497>