From owner-cvs-all@FreeBSD.ORG Wed Jun 15 11:52:53 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0C1A716A41C; Wed, 15 Jun 2005 11:52:53 +0000 (GMT) (envelope-from dejan.lesjak@ijs.si) Received: from mail.ijs.si (mail.ijs.si [193.2.4.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id AE38E43D1F; Wed, 15 Jun 2005 11:52:52 +0000 (GMT) (envelope-from dejan.lesjak@ijs.si) Received: from localhost (mail.ijs.si [193.2.4.66]) by patsy.ijs.si (Postfix) with ESMTP id 858D417B85C; Wed, 15 Jun 2005 13:52:51 +0200 (CEST) Received: from patsy.ijs.si ([127.0.0.1]) by localhost (patsy.ijs.si [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 72471-02-4; Wed, 15 Jun 2005 13:52:49 +0200 (CEST) Received: from idefix.ijs.si (idefix.ijs.si [193.2.4.33]) by patsy.ijs.si (Postfix) with ESMTP id 564A617B86F; Wed, 15 Jun 2005 13:52:48 +0200 (CEST) Received: from localhost.ijs.si (localhost.ijs.si [127.0.0.1]) by idefix.ijs.si (Postfix) with ESMTP id A10335C0A; Wed, 15 Jun 2005 13:52:48 +0200 (CEST) From: Dejan Lesjak To: Alexander Leidinger Date: Wed, 15 Jun 2005 13:52:47 +0200 User-Agent: KMail/1.8 References: <200506150243.j5F2habT053985@repoman.freebsd.org> <200506151217.05514.dejan.lesjak@ijs.si> <20050615131035.wyn4a6julw80ow4c@netchild.homeip.net> In-Reply-To: <20050615131035.wyn4a6julw80ow4c@netchild.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200506151352.48180.dejan.lesjak@ijs.si> X-Virus-Scanned: amavisd-new at ijs.si Cc: Dejan Lesjak , cvs-ports@FreeBSD.org, Michael Johnson , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/astro/gpsdrive pkg-plist ports/audio/gqmpeg-devel pkg-plist ports/databases/pgworksheet pkg-plist ports/deskutils/hot-babe pkg-plist ports/deskutils/xchm pkg-plist ports/editors/abiword-devel pkg-plist ports/games/crimson ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jun 2005 11:52:53 -0000 On Wednesday 15 of June 2005 13:10, Alexander Leidinger wrote: > Dejan Lesjak wrote: > > On Wednesday 15 of June 2005 12:07, Alexander Leidinger wrote: > >> Michael Johnson wrote: > >> > On Jun 14, 2005, at 10:43 PM, Dejan Lesjak wrote: > >> >> lesi 2005-06-15 02:43:36 UTC > >> >> > >> >> FreeBSD ports repository > >> >> > >> >> Log: > >> >> Directory share/pixmaps is now included in mtree > >> >> (BSD.x11-4.dist rev. 1.27), so remove it from plist. > >> > > >> > sweet! > >> > >> We need to bump the revision number of those ports, else no updated > >> packages will be generated. > > > > The packages should include mtree that is present when they are generated > > (at least as far as I understand this). So there's no need to generate > > packages that only move a directory from +MTREE_DIRS to +CONTENTS. > > I was talking about the case where a directory moved from +CONTENTS to the > mtree file. We don't want to remove a mtree directory in such a port, don't > we? Well, if they are empty, why not? It is actually rather unavoidable. I could be missing something, but this is how I understand things: - packages made before this change will have share/pixmap in +CONTENTS, so this directory will get removed if it is empty and there is nothing we can now do about that, since those packages with their +CONTENTS are already installed on users machines. Nothing however should break because of this since (1) packages that would rely on this directory being present already have it listed either in +CONTENTS or +MTREE_DIRS and (2) things outside of packages that would rely on this directory present would already be broken before since these packages removed share/pixmaps directory if empty already. - packages made after this change will have share/pixmaps in +MTREE_DIRS, so it won't get removed upon deinstall of such packages. This shouldn't be a problem as far as I can see. Dejan