From owner-svn-src-all@freebsd.org  Sun Aug 18 15:37:20 2019
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9A089C9FE1;
 Sun, 18 Aug 2019 15:37:20 +0000 (UTC)
 (envelope-from mmel@FreeBSD.org)
Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org
 [IPv6:2610:1c1:1:606c::19:3])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "mxrelay.nyi.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 46BLlh3Wjfz4fNV;
 Sun, 18 Aug 2019 15:37:20 +0000 (UTC)
 (envelope-from mmel@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 561F943C8;
 Sun, 18 Aug 2019 15:37:20 +0000 (UTC)
 (envelope-from mmel@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id x7IFbKaj048955;
 Sun, 18 Aug 2019 15:37:20 GMT (envelope-from mmel@FreeBSD.org)
Received: (from mmel@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id x7IFbKbo048954;
 Sun, 18 Aug 2019 15:37:20 GMT (envelope-from mmel@FreeBSD.org)
Message-Id: <201908181537.x7IFbKbo048954@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: mmel set sender to
 mmel@FreeBSD.org using -f
From: Michal Meloun <mmel@FreeBSD.org>
Date: Sun, 18 Aug 2019 15:37:20 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r351189 - head/sys/dev/fdt
X-SVN-Group: head
X-SVN-Commit-Author: mmel
X-SVN-Commit-Paths: head/sys/dev/fdt
X-SVN-Commit-Revision: 351189
X-SVN-Commit-Repository: base
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 18 Aug 2019 15:37:20 -0000

Author: mmel
Date: Sun Aug 18 15:37:19 2019
New Revision: 351189
URL: https://svnweb.freebsd.org/changeset/base/351189

Log:
  Fix bug introduced by r351184.
  We should check the returned handle, not the pointer to it.
  
  Noticed by:	ian
  X-MFC with:	r351184
  MFC after:	1 week

Modified:
  head/sys/dev/fdt/simple_mfd.c

Modified: head/sys/dev/fdt/simple_mfd.c
==============================================================================
--- head/sys/dev/fdt/simple_mfd.c	Sun Aug 18 11:43:58 2019	(r351188)
+++ head/sys/dev/fdt/simple_mfd.c	Sun Aug 18 15:37:19 2019	(r351189)
@@ -134,7 +134,7 @@ simple_mfd_syscon_get_handle(device_t dev, struct sysc
 
 	sc = device_get_softc(dev);
 	*syscon = sc->syscon;
-	if (syscon == NULL)
+	if (*syscon == NULL)
 		return (ENODEV);
 	return (0);
 }