From owner-svn-src-head@freebsd.org Thu Nov 19 03:53:32 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0FECAA31167; Thu, 19 Nov 2015 03:53:32 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0117.outbound.protection.outlook.com [207.46.100.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "MSIT Machine Auth CA 2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DB58E1784; Thu, 19 Nov 2015 03:53:30 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from BY2PR05CA055.namprd05.prod.outlook.com (10.141.250.45) by BL2PR05MB051.namprd05.prod.outlook.com (10.255.228.151) with Microsoft SMTP Server (TLS) id 15.1.331.20; Thu, 19 Nov 2015 03:53:24 +0000 Received: from BN1BFFO11FD035.protection.gbl (2a01:111:f400:7c10::1:192) by BY2PR05CA055.outlook.office365.com (2a01:111:e400:2c5f::45) with Microsoft SMTP Server (TLS) id 15.1.331.20 via Frontend Transport; Thu, 19 Nov 2015 03:53:23 +0000 Authentication-Results: spf=softfail (sender IP is 66.129.239.17) smtp.mailfrom=juniper.net; FreeBSD.org; dkim=none (message not signed) header.d=none;FreeBSD.org; dmarc=none action=none header.from=juniper.net; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning juniper.net discourages use of 66.129.239.17 as permitted sender) Received: from p-emfe01a-sac.jnpr.net (66.129.239.17) by BN1BFFO11FD035.mail.protection.outlook.com (10.58.144.98) with Microsoft SMTP Server (TLS) id 15.1.331.11 via Frontend Transport; Thu, 19 Nov 2015 03:53:22 +0000 Received: from magenta.juniper.net (172.17.27.123) by p-emfe01a-sac.jnpr.net (172.24.192.21) with Microsoft SMTP Server (TLS) id 14.3.123.3; Wed, 18 Nov 2015 19:53:21 -0800 Received: from chaos.jnpr.net (chaos.jnpr.net [172.21.16.28]) by magenta.juniper.net (8.11.3/8.11.3) with ESMTP id tAJ3rKD44632; Wed, 18 Nov 2015 19:53:20 -0800 (PST) (envelope-from sjg@juniper.net) Received: from chaos (localhost [IPv6:::1]) by chaos.jnpr.net (Postfix) with ESMTP id BB93D580A9; Wed, 18 Nov 2015 19:53:19 -0800 (PST) To: Bryan Drewery CC: , , , Subject: Re: svn commit: r288966 - head/share/mk In-Reply-To: <564D29A0.6040000@FreeBSD.org> References: <201510070032.t970WYvU099368@repo.freebsd.org> <56146B4E.5040401@FreeBSD.org> <24053.1444240925@chaos> <56155FE0.7020809@FreeBSD.org> <564D29A0.6040000@FreeBSD.org> Comments: In-reply-to: Bryan Drewery message dated "Wed, 18 Nov 2015 17:45:04 -0800." From: "Simon J. Gerraty" X-Mailer: MH-E 8.6; nmh 1.6; GNU Emacs 24.5.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <12768.1447905199.1@chaos> Date: Wed, 18 Nov 2015 19:53:19 -0800 Message-ID: <15117.1447905199@chaos> X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD035; 1:VkC0lXg4EWOJade/vGXF3IqvQk2GLcIOkSj+4m2T329h+WkH7ARjZpFG/uoPWdt/WU/gCcHNOQX90+tDK7c5DB+rHfqSjVoyznP7T+/MAVmCxF0kRjOtL/w/7cZGpiZHkG7yLQ+fwuwlDf1N37JUh2+cOvzpWooG5hguqoufoeNtkrmIWRPDYF+aHyume/23fQ1aDg3PKkxvQZyi59SkQKU65zm7+vXHPEsh2Tq12nQNHY5uOL/uPdFyeNdw1lOy9KNMQm5sTWUpk4ylg+FBZg4mPuSuQpPyGSAinc2p6IWTR9clvWzq3uhYQtVXvxFWXuKaAhhwcWk4M+Kk+PczrJ8U6CF11MxTX4iNUxH0+SM= X-Forefront-Antispam-Report: CIP:66.129.239.17; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(2980300002)(24454002)(189002)(199003)(5007970100001)(19580395003)(107886002)(5001960100002)(106466001)(19580405001)(110136002)(189998001)(50986999)(46406003)(97756001)(450100001)(76176999)(5008740100001)(105596002)(87936001)(6806005)(86362001)(4001430100002)(47776003)(97736004)(50466002)(69596002)(117636001)(93886004)(57986006)(2950100001)(50226001)(77096005)(81156007)(76506005)(33716001)(586003)(92566002)(23726002)(42262002)(62816006); DIR:OUT; SFP:1102; SCL:1; SRVR:BL2PR05MB051; H:p-emfe01a-sac.jnpr.net; FPR:; SPF:SoftFail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2PR05MB051; 2:75aRZrByUWuchBS6I+h7QcYqh7gajWyEhVXQ7dVQv7fltZUQirSqkhYQ9v/w56YGip9fD3fFjOXP5gWCBExj2PtWVHJot2giETw06AMVi3lFHhYrt2MMjUngcf0LGC9u1HFK7snHcHPalnywN9xRRg==; 3:SIZMxLRFncGzKHdgCVLprQ6MwCaoAUdJ+ZvKhgmGrkGQj1yktTmuunWlwU7M8vKddcQ+pW4duWbA+gWS71L2rwEGRqjHH4thdsmgGIvcn9uW1YOVrwGpIW9Lmu+mx8PqVdnVYHc3ia2QoQoPnHXVoHtiTJv5bZnSqrpjUJhWG1XvkhraNGrC8NINfzBF2WCiv74FuQgBaYGIRJO2P2OD6Y3pN0JteO4Ca/Hia22c3PQ=; 25:pJCehgmcnpHmCLCCVME5cACVLQRXl7gsBwB/e68tPpE62Ep1ItW7LXlDvIuuyuTSla/EvVopuSzcUR0DE9FnU+va20RX7MtjZVdIY0vuwIURWC0uucTiBxhG3bMGUPl/evbGgGZ71tG6NNE6eFkd3sLpJhccesiWGdOKbrrQRkdB7cQEzoUCpld1qRcyTxEAg3KAQpf/5sEvZ2BBArXPPjY6HVFoC5I3giYu4djC2awY584iQWErAiWxahQOeIgg X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BL2PR05MB051; X-Microsoft-Exchange-Diagnostics: 1; BL2PR05MB051; 20:77GJ0yuNr5t/jCn1Yo/OYa7QyfvpxOxpoaUr6AH7xKz+CKKtIgtoTwL1uxujyOY9HwptIa5caGE2n3GtvuS2iRYJWNvDK5RlMt3WdzoACqqF8dAyNtdAnAIeP4pSWSQamEbhIyyyleXkCh0UNYvlp/C2SOacav5fCYZq10VST5fX2oIRIfwmTVvDqFCZIpOTTARp3u5q6t9f1jJb6mk+aJz5hLPiXMlDbGwRQgP60DVVcMuir9xYqJYjO0qJlokQKY36oVKQwEd97iqbayo2j1iSKAJ5sjTXFY7MaVVEYE/dq983Qz3z6XUbZi/LdLTi8fc/Lr+UyawVsygZgTvoJatw0HdxidwX8ZhCm9yto9zSDV9zywvQbeuI7yK4DV/+w2mCTDCR+vHoZKoBsxWySSTgHSFGfjjqMyrsDTPmT97Ci2wmLvvGdo4WOuKgzHGFIw1B+XGchJcHa8AMwHWeto0pMF9V0ArTV4CWPnAIEwdpo3LS31YI9uhqIjzNzGaD; 4:vQuIvaWbgZz2lSN9k7WP6lof5V5mgFEssHaweTM3TR2hjxcIC/1dSK5IH+btZSUSkiXZzN/tmAeKl9mqLWR7LGPwa5U8uVGwzR8+k5vqhZUfOBl1QY3Bi7Qf/CB03CcDi5/lUvRpivlFD0UUml9tlalONkWMaQijDvYaZqiKAL0pAPKdXufYSZhM6qDSCZVgMyzr3CTI7CImUEix68kSnf5RuIIuzf6cYo0eK45Or34ClSsQuY0OlWKQoAKGQjAUnbhRgYyF016LVqKRBObTJCnpk3SRwsfc2DKJuvtUotEuLkg+g27+XJim0o7aXaQPiLZCyCyXX3mYOjOZlKvC7vAxtUhQI+AstOGZSLiMhYOY8j6T/qqzYsXd0rqc8NrU X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(10201501046)(3002001); SRVR:BL2PR05MB051; BCL:0; PCL:0; RULEID:; SRVR:BL2PR05MB051; X-Forefront-PRVS: 07658B8EA3 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BL2PR05MB051; 23:miimZyIY0xo8Gkzjq2Ygxf7Imkiv0wyJh+VoBcoU+V?= =?us-ascii?Q?jCPSaAfAohfvPbZBCm6jlg7iypfSJmjWiJ0O3dMsY3f6B+Bfagh7fKoBJ3w3?= =?us-ascii?Q?i2KLClc72BdjSiZbO/3/0PbGHHjD9eZk5g6sjQckRucw+CfeSR+EOcuMfOyZ?= =?us-ascii?Q?YedWifUcd/5Oh1QCqgQJem8iwQDJXN4OYnfgfX1a8UJc9WfcZwfWsRY3XJ3a?= =?us-ascii?Q?riGvxijCnPIo5Y2/o8vPW7GdJDpCMEEG8iNfK1Eg8NsPV0yI6ygpfKeG7U2n?= =?us-ascii?Q?LvFr0qIYzq1nDcmgOFAtDka9H3EKFC6q8NaqepW4eRSB2fHNFaXJQekAAJTi?= =?us-ascii?Q?zRCH65IEEL1Mp57uMRcLFkT6ryzcXPVv60om0O7uwlEMXMoBAu7zQXNjVLIV?= =?us-ascii?Q?kROkiSFB4Xt2pd99IGIhUNtpRoqrFiFbtMBdpF0u6slGK+b0021EvodPTcmp?= =?us-ascii?Q?G8HSlrTJNIkdw9PN3qBYg5bhtKotGC3kBefb9XP88jjxi4fXfapl+YYC/4Es?= =?us-ascii?Q?nTC5ns2IvQ1fr+zmMFz+vwLvLarX3Nc49ADQlAcZ/RmKiK8/05h/AxekxCbC?= =?us-ascii?Q?5TmQUpADww2ko9GaNpI6VUYlmkZtgviVZh8J/vcsU42etLryqsX0CgKXRL0/?= =?us-ascii?Q?gt4qKjqEG1yQc5hnu/NdC3pPMIkarT1hIMZ2BtDxZ10BeAdqQEX+R8jsNdjQ?= =?us-ascii?Q?hQcsr9mDgiP19oBB9r/kBQwcYASDqjPqJxrbTQ9lMBtUn38asufhCV965O4c?= =?us-ascii?Q?bzGOrt7OoCSccamKhRj5FoEMwKgtEBwHlEQW21sj1uDTv3YrUH/d1YMlGu/6?= =?us-ascii?Q?33EKxFWzhVaB9KOnSxuu/s0SdJa0JctYrVyEZGX/3P81GwBrAYbuQcdHxMEg?= =?us-ascii?Q?WN8jYSV1vd0G0XB5ib3hGMM8TlfUPS1BWdCrln4w3I//3jszArq8ALX7EZoS?= =?us-ascii?Q?u+FFk1stBORSA88mDRMhNK2YiTu91JX/y3+6+v4wO5xcJhQzCCJvsXN1jvwo?= =?us-ascii?Q?89JpRjPM17NHg9jFoqFlNmAh8092Wdef5J7zFbD7Fjg1MJrSObgI2llzQmUz?= =?us-ascii?Q?fzteaSMLGfDORiR4TKzOQl+EZX8eVmJEzjR82KL5n62/reb0xZQsbjfa8NII?= =?us-ascii?Q?svruyiSrA=3D?= X-Microsoft-Exchange-Diagnostics: 1; BL2PR05MB051; 5:SDgmvO/NSx+mCvRwkYl5Fi44Hsu2IC/Bu3FvOJt/13tIVSwCG7/R7ZJftqV4GJ3xJq7a9bKekaFZJO2jE1deLTv9r4fhzkRv4ovMRztu+yMkOPUOh1npc7LjuWWE6YGr3DKuLLeTxeiMrRyXz5K7WA==; 24:lgzc97F86AgW6oWwQWppr1iQwPM7hnoguFUOgtzhWqK0G0JN0aNBuWo6IyooqtBCiXdEWJkY6GAhkPtg6oTd0TkmnVcZ+mBa8MxIwtxbHsQ= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2015 03:53:22.7444 (UTC) X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4; Ip=[66.129.239.17]; Helo=[p-emfe01a-sac.jnpr.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR05MB051 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Nov 2015 03:53:32 -0000 Bryan Drewery wrote: > As for the actual change in local.autodep.mk, I don't think it is needed > or right since bsd.lib.mk and bsd.prog.mk already do exactly the same > thing via ${OBJS}: ${SRCS:M*.h} if .depend is not yet generated. This > does work in meta mode as I ran into a failure due to it before r291046 > (I had removed the libbfd/Makefile.depend.host for other testing). It's > also hooked in far too late and orthogonally to the OBJS in the graph > that need the headers. Forgive me; what is "it" in the last sentence? It is never too late to add a dependency. It can easily be too late to add a value to a variable - to affect dependencies. Eg. goo: ${OBJS} echo OBJS=${OBJS} OBJS+= foo.c will not behave as 99% of readers assume. foo.c being newer than goo, will not cause the target to be updated because in goo: ${OBJS} OBJS is evaluated as the line is read. Whereas echo OBJS=${OBJS} is evaluated when the script is run which is much later in the game. OBJS+= foo.c goo: foo.c would be correct fwiw.