From owner-p4-projects@FreeBSD.ORG  Fri Apr 11 11:42:51 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id D9AA637B401; Fri, 11 Apr 2003 11:42:50 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6A71B37B405
	for <perforce@freebsd.org>; Fri, 11 Apr 2003 11:42:50 -0700 (PDT)
Received: from mail.speakeasy.net (mail16.speakeasy.net [216.254.0.216])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5F65C43F93
	for <perforce@freebsd.org>; Fri, 11 Apr 2003 11:42:49 -0700 (PDT)
	(envelope-from jhb@FreeBSD.org)
Received: (qmail 18295 invoked from network); 11 Apr 2003 18:42:55 -0000
Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63])
	(envelope-sender <jhb@FreeBSD.org>)encrypted SMTP
	for <perforce@freebsd.org>; 11 Apr 2003 18:42:55 -0000
Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1])
	by server.baldwin.cx (8.12.8/8.12.8) with ESMTP id h3BIglOv056078;
	Fri, 11 Apr 2003 14:42:47 -0400 (EDT)
	(envelope-from jhb@FreeBSD.org)
Message-ID: <XFMail.20030411144247.jhb@FreeBSD.org>
X-Mailer: XFMail 1.5.4 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <200304110633.h3B6XTJw085790@repoman.freebsd.org>
Date: Fri, 11 Apr 2003 14:42:47 -0400 (EDT)
From: John Baldwin <jhb@FreeBSD.org>
To: Peter Wemm <peter@FreeBSD.org>
cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: RE: PERFORCE change 28754 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Apr 2003 18:42:51 -0000


On 11-Apr-2003 Peter Wemm wrote:
> http://perforce.freebsd.org/chv.cgi?CH=28754
> 
> Change 28754 by peter@peter_daintree on 2003/04/10 23:32:49
> 
>       OK, I have to laugh about this one.
>       keep gcc-3.3 happy where long > int (speed_t is
>       unsigned int)

Why not use UINTMAX? if speed_t is an int?  Or perhaps
speed_t should be a long instead?

> Affected files ...
> 
> .. //depot/projects/hammer/sys/dev/sio/sio.c#9 edit
> 
> Differences ...
> 
> ==== //depot/projects/hammer/sys/dev/sio/sio.c#9 (text+ko) ====
> 
> @@ -1542,8 +1542,12 @@
>       u_int   divisor;
>       int     error;
>  
> -     if (speed == 0 || speed > (ULONG_MAX - 1) / 8)
> +     if (speed == 0)
> +             return (0);
> +#if UINT_MAX > (ULONG_MAX - 1) / 8
> +     if (speed > (ULONG_MAX - 1) / 8)
>               return (0);
> +#endif
>       divisor = (rclk / (8UL * speed) + 1) / 2;
>       if (divisor == 0 || divisor >= 65536)
>               return (0);

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/