From owner-cvs-all@FreeBSD.ORG Thu Sep 27 19:29:12 2007 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5546B16A419; Thu, 27 Sep 2007 19:29:12 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id B627113C448; Thu, 27 Sep 2007 19:29:11 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8p) with ESMTP id 211740089-1834499 for multiple; Thu, 27 Sep 2007 15:27:50 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l8RJSrXk039145; Thu, 27 Sep 2007 15:28:57 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: src-committers@freebsd.org Date: Thu, 27 Sep 2007 14:48:29 -0400 User-Agent: KMail/1.9.6 References: <200709271839.l8RIdJ7f050638@repoman.freebsd.org> In-Reply-To: <200709271839.l8RIdJ7f050638@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200709271448.30000.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Thu, 27 Sep 2007 15:28:57 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4414/Thu Sep 27 14:04:10 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern subr_turnstile.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Sep 2007 19:29:12 -0000 On Thursday 27 September 2007 02:39:19 pm John Baldwin wrote: > jhb 2007-09-27 18:39:18 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_6) > sys/kern subr_turnstile.c > Log: > - Remove some debugging nits in the MFC of rwlocks that looked for cases > where a reader blocked on a lock with no owner and just assert that it > never happens like HEAD. > - Actually set td->td_tsqueue to the sub-queue of a turnstile that a > thread is actually enqueued to. Otherwise, the kernel would always > think that threads were on the queue for exclusive (write) waiters > (queue 0). Thus, if the priority of a thread waiting on a read lock > was adjusted while it was waiting it could result in corrupting the > queue of waiting threads. Oops, forgot to mention that this should also fix kernel page faults when a reader unlocks a rwlock with waiting writer(s). -- John Baldwin