From nobody Wed Mar 25 15:58:31 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fgs5S5RrFz6WS0d for ; Wed, 25 Mar 2026 15:58:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fgs5S3XFYz3Kjf for ; Wed, 25 Mar 2026 15:58:36 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774454316; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pzsC6Kh8xqLuA8WPAunkYEpGEjsPzwrTrcHHlBJyvFo=; b=GiFkCiBjTQC50oPj4tb7nwA6gV3EgBTmKQiXk/JAZIrC5My3fi9vn/Zi1eb1OEE+8qOKwE tQAowBVnlRVkiYMS8vv7Btta1za0N+26H8RsVw953OgDUu2a54kHistxkn/NRacsgalLsx /WYy57nrWxWAZJ1LFzYbRNbE/dU3U17eqFOSt7heGzs2Mh1mkdXViBGC8P0IyEjdzOd77N +jWXXz2mJ6vXcDS7QiKTcoIP/SPzM7M4RyC1V9ewf31rZuNkprGYlVRmxX2uG0h6TxCJsG edqpguacp8zlsxnAkVN4pKgNZ/eKtP9kAedPzXLEMVUcCZuODnnwqbCGwl5JoA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1774454316; a=rsa-sha256; cv=none; b=wzN3/PT/AaCUIU1WJ4cQlc+/PicgR2n3pmsmKMATNXgFET/kwB4kPMzXWyJJqkS+Am4aSV Af6PEN1JWsMLcux4CqHh3TjL40/7vlzojShYG+q0sWvSSwIXqNSW/+1stWTqcntj5OSRC3 IP92gA0D0uGG8kDAL2nY0hLALb5ab6VVPKKqyG/hNyZmvVT00jh7qCL74+ESc95lmuaY2O TidLS8l/TbcCRG8eSM1R7qA3VZsSw79IjgJIG9oKFs4cMLU1zHuAFYiKhzNXafrLccKG4Q Vl2HksP8lGmOFLLBBxh6jep6TlUfSA+SskqRRhpyBJfRaWgcF2IA2XUf8Tkfpg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774454316; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pzsC6Kh8xqLuA8WPAunkYEpGEjsPzwrTrcHHlBJyvFo=; b=AdrxKwUBnbCRa5pdrn35k0V2SCJyMsxohS6oVH3NePMMmT6Rj6HOjr0xhFQF+TGnRKh84/ tM80JIALVB9Q5nEQDwPsxydwWv4YpnnJVfpz5pVYVR0WKqGhecRfv1ghf5oIjeVkivSRfn AN95S0T3MD+7nJXgxBlrsiUs3X41SKBB0p56Lzae9gRcZM/3ilb5lI07+N9picppgtL9oR +Tl9/mFgiFL/iuWCsuLYpWsx/ErVg9HI5xrqEbYuRi3eE536LQ8jmj+SrjKdn62VD3A/uk 63TQ1E6lhPoy3ow4dtlsOiG3+BthQ/8/OlkB/7GVKK+oymU3TVQUudGL6+GGcw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fgs5S382Yz1BS6 for ; Wed, 25 Mar 2026 15:58:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 268b1 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 25 Mar 2026 15:58:31 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Cochard Subject: git: 648d0fefd757 - main - ipfw: skip tests if required sysctl is not set List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olivier X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 648d0fefd7573080b01d44cad8c39ad658f8e44f Auto-Submitted: auto-generated Date: Wed, 25 Mar 2026 15:58:31 +0000 Message-Id: <69c40627.268b1.1b51d5ca@gitrepo.freebsd.org> The branch main has been updated by olivier: URL: https://cgit.FreeBSD.org/src/commit/?id=648d0fefd7573080b01d44cad8c39ad658f8e44f commit 648d0fefd7573080b01d44cad8c39ad658f8e44f Author: Olivier Cochard AuthorDate: 2026-03-25 15:47:44 +0000 Commit: Olivier Cochard CommitDate: 2026-03-25 15:55:57 +0000 ipfw: skip tests if required sysctl is not set Since this is a configuration prerequisite rather than a test failure, use atf_skip instead. Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D56069 --- tests/sys/netpfil/common/utils.subr | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/sys/netpfil/common/utils.subr b/tests/sys/netpfil/common/utils.subr index 8f298960bef5..8885495cec11 100644 --- a/tests/sys/netpfil/common/utils.subr +++ b/tests/sys/netpfil/common/utils.subr @@ -88,7 +88,7 @@ firewall_init() if ! kldstat -q -m ipfw; then atf_skip "This test requires ipfw" elif [ $(sysctl -n net.inet.ip.fw.default_to_accept) -ne 1 ]; then - atf_fail "ipfw tests require net.inet.ip.fw.default_to_accept=1 tunable" + atf_skip "ipfw tests require net.inet.ip.fw.default_to_accept=1 tunable" fi elif [ ${firewall} == "pf" ]; then if [ ! -c /dev/pf ]; then