From owner-freebsd-current@FreeBSD.ORG Wed May 28 08:28:22 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C2AC337B401; Wed, 28 May 2003 08:28:22 -0700 (PDT) Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11]) by mx1.FreeBSD.org (Postfix) with SMTP id 6A73743FAF; Wed, 28 May 2003 08:28:21 -0700 (PDT) (envelope-from dwmalone@maths.tcd.ie) Received: from walton.maths.tcd.ie by salmon.maths.tcd.ie with SMTP id ; 28 May 2003 16:28:20 +0100 (BST) To: Robert Watson In-reply-to: Your message of "Wed, 28 May 2003 11:19:45 EDT." X-Request-Do: Date: Wed, 28 May 2003 16:28:20 +0100 From: David Malone Message-ID: <200305281628.aa67444@salmon.maths.tcd.ie> cc: current@FreeBSD.org Subject: Re: mb alloc and: panic: mutex Giant not owned at ../../../vm/vm_kern.c:315 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 May 2003 15:28:23 -0000 > > This may be my fault, as I made some changes recently that assumed that > > the mbuf allocator grabbed giant when needed. I'll check the code path > > you've mentioned to see if it grabs giant now, but I suspect that I just > > need to move the giant grabbing back where it was before. > This doesn't seem to be a reproduceable problem for me, FWIW, (presumably > a property of bucket sizes, etc) so you have all the information I have > :-). You'd have to be quite unlucky to trigger it (calling sendit at a time when a per-cpu mbuf pool was empty). I have a vague feeling that my sendit change isn't the only place that does this. > If possible, we should get this fix in for 5.1? Yep - from what Bosko says, my change shouldn't have been safe. I'll produce a patch and run it by him, and then talk to re@. David.