From nobody Sun Mar 3 10:30:46 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TndQK1Hpxz5CVNL; Sun, 3 Mar 2024 10:30:49 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TndQK0r7Jz4dHl; Sun, 3 Mar 2024 10:30:49 +0000 (UTC) (envelope-from mat@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1709461849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6NqcbgMpXwuENjJ2whJFWXD0foeUW24E9Cj9u3Xy+zE=; b=mtklxg4CVlEvs6LjaTbKhiQRWHUsGFhexL9xb78aL+JU337aPH9oWlsUS0UTVBDmW8soJF fdTlZWjklGglCIPpM7ZZykv0acY3vqAHbT5+G+ZMDzCVniA2gvXCFvpYys6axxhYQn3KDn 3tF0jP4TvkyExH+H30LqtVG5EtWbo0ENIGmqsG/U6mS1OB5zXxNTMfhzEmXFZQPyf9i4Ni hqNJVZBDmYw3JJI4SaO20UmkIE5yjuX1mRFXZUQc8jPc6fb9w9odWZHRdNY4WmDoTltU7A mPJcPmsLVIsCwHF1UYFUB9qjALGj4saJufBuDV/8I2aRkDgzY9Ifiv9P702RHg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1709461849; a=rsa-sha256; cv=none; b=CAKvwdsUGgWWzE3SJB5+XI535iFVDjno+3rdSGkKy6qawpDf6wr03taIybqJgYC4aw0pOY OuzYNmcKxxkxFwewrnfEV7fWS5oalWPjHeCMQRhYFR9zcShnhT4n21kbVOgE4EqLFA50wI qhe4A1yt4BOahIpUymrmXfB+dMMBh1R0X906zEdjjyJri/cFJT5EVrLb5jTzJv0ZO1mJCa Y6pyiuiJ31zB4DbpkA+g/vr902R3M5JudHwH4bGyqyny+qai+qOReuWDTJ0VoO8GRuB/gX eZjWFENSe3iDZr1CF+v5vAm2IIVuxkw65ZI+8t41VvTThYzBWkHC8ZIg9Oy2UQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1709461849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6NqcbgMpXwuENjJ2whJFWXD0foeUW24E9Cj9u3Xy+zE=; b=K2jzJVKQxN9WflbswSGh5223ORhJsE7Pu+qIv1m5Aq0FlD1Sa9/NvPST6SF3lmZxDR+JCn RQy+lbEQdTa9FDhz70gVIqvYX0abHWY/DAGirTqHX6jIUcQtXIEaG5HgRmr+xXJmCtLe4v h8SKlZ9epJ+ijahY9N/ma3qvzUAOFntoeJB5TB5IsVxiKtLn+bB4tJV1HhwI0VtQP2L8zG nvHu/Pvy1zGodaMW1BoZO07oUWHgJgU+w3dRhMx+Slu0Mx5gvuddFlrOEuhI4iuu9/MgYx J2JEoa9n5s7PMHQ0nCaFq/AJaBjGVEDwB7KYR+fH/PhEPDhzalzkNyk1Misk4w== Received: from relay.mat.cc (cow.mat.cc [79.143.244.49]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "cow.mat.cc", Issuer "R3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4TndQJ6q2gz13M3; Sun, 3 Mar 2024 10:30:48 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from aching.in.mat.cc (unknown [IPv6:2a01:e0a:836:f670:c19d:9574:508c:2978]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by relay.mat.cc (Postfix) with ESMTPSA id D35F5209F9; Sun, 3 Mar 2024 11:30:47 +0100 (CET) Date: Sun, 3 Mar 2024 11:30:46 +0100 From: Mathieu Arnold To: Gleb Popov Cc: Thomas Zander , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: a995b8b0ab54 - main - multimedia/{mplayer/mencoder}: Move DEBUG from OPTIONS to WITH_DEBUG Message-ID: <5rhletz56xtstyf24ly4pq63grgs3sfgzjlg7ojpdhw66mjsge@xh7bxfu44ifq> References: <202403021836.422Ia4o2021754@gitrepo.freebsd.org> <5l6vknhs4q4ljz5fe52ksdofxsnfaautnuetnqeb5cbj5c2uay@qbtuvdsmy7fk> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ju5pqq7ef5erjj2y" Content-Disposition: inline In-Reply-To: --ju5pqq7ef5erjj2y Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 03, 2024 at 12:01:41PM +0300, Gleb Popov wrote: > On Sun, Mar 3, 2024 at 11:56=E2=80=AFAM Mathieu Arnold = wrote: > > > > There is no trend, it's a rule, debug must be handled with WITH_DEBUG > > knob, and not via an option. > > If there is an option that enable some sort of debugging or verbose > > thing but that is not supposed to add debugging symbols, then it should > > not be called DEBUG. >=20 > In that case we need a qa check that prevents adding DEBUG option and > then we can also introduce a generic DEBUG_VAR helper to get rid of > ifdefs? Oh, sorry, I made a mess of things, and I woke up completely, my brain short circuited for a while. A DEBUG option is fine, as long as it MUST NOT enable WITH_DEBUG. WITH_DEBUG is a user facing variable, that MUST NOT be set in a port. --=20 Mathieu Arnold --ju5pqq7ef5erjj2y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmXkUVZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb7MUAwAzOnBcS2vo8cuPvRVF0cWilN/iQuWH+SOqX5KooRjo5VNiiK2ykRsU+3U wp0OJNmFvz6apDMKabXL4gHPL4kIgeiszAWnQVOvdTpDwsIIggBe2bFsfkOks7Kw OYQgRcFZlBlGVfUJlLzWG/5VqjENu+amhymslfxKjz51xBFbWj8Ebp5tzGdmzHxE wqnnB/10vOEL2U9gAumYEO5UFP7tvubcYsrNpBGsJ6jhp7hOF6F9X8/2WOZvDgS/ 2nvUrq75AtFKov+2yu4GRZ7Ymz31bJ+FB9O0y2lMuLY9SkBCCT/gXlgTn1WxY5vW e5XfuYpVgQv5j+LdFHi8zarQ6/bnjoS8qSVbVX8DyesGEmkSrhe2KV2fUuNuWf9a LBnLRoVzsIppnuT39ntPuNm0WMAljsCqe/PkGtxWbBWZcdzGMZZU8GVAjk+Juklw suvWKS78cI07dC8xsfI27PYlmir8wgHml2ox57jRcSri/jjCkVR+fO1iOZWKSigC KcQLZlMP =dREH -----END PGP SIGNATURE----- --ju5pqq7ef5erjj2y--