Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 18 Jul 2018 22:49:54 +0000 (UTC)
From:      Randall Stewart <rrs@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r336465 - in head/sys/netinet: . tcp_stacks
Message-ID:  <201807182249.w6IMns6D076446@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: rrs
Date: Wed Jul 18 22:49:53 2018
New Revision: 336465
URL: https://svnweb.freebsd.org/changeset/base/336465

Log:
  Bump the ICMP echo limits to match the RFC
  
  Reviewed by:	tuexen
  Sponsored by: Netflix Inc.
  Differential Revision:		https://reviews.freebsd.org/D16333

Modified:
  head/sys/netinet/ip_icmp.c
  head/sys/netinet/tcp_stacks/rack.c

Modified: head/sys/netinet/ip_icmp.c
==============================================================================
--- head/sys/netinet/ip_icmp.c	Wed Jul 18 22:45:45 2018	(r336464)
+++ head/sys/netinet/ip_icmp.c	Wed Jul 18 22:49:53 2018	(r336465)
@@ -139,8 +139,8 @@ static VNET_DEFINE(int, icmp_rfi) = 0;
 SYSCTL_INT(_net_inet_icmp, OID_AUTO, reply_from_interface, CTLFLAG_VNET | CTLFLAG_RW,
 	&VNET_NAME(icmp_rfi), 0,
 	"ICMP reply from incoming interface for non-local packets");
-
-static VNET_DEFINE(int, icmp_quotelen) = 8;
+/* Router requirements RFC 1812 section 4.3.2.3 requires 576 - 28. */
+static VNET_DEFINE(int, icmp_quotelen) = 548;
 #define	V_icmp_quotelen			VNET(icmp_quotelen)
 SYSCTL_INT(_net_inet_icmp, OID_AUTO, quotelen, CTLFLAG_VNET | CTLFLAG_RW,
 	&VNET_NAME(icmp_quotelen), 0,

Modified: head/sys/netinet/tcp_stacks/rack.c
==============================================================================
--- head/sys/netinet/tcp_stacks/rack.c	Wed Jul 18 22:45:45 2018	(r336464)
+++ head/sys/netinet/tcp_stacks/rack.c	Wed Jul 18 22:49:53 2018	(r336465)
@@ -1627,7 +1627,6 @@ rack_process_rst(struct mbuf *m, struct tcphdr *th, st
 static void
 rack_challenge_ack(struct mbuf *m, struct tcphdr *th, struct tcpcb *tp, int32_t * ret_val)
 {
-
 	INP_INFO_RLOCK_ASSERT(&V_tcbinfo);
 
 	TCPSTAT_INC(tcps_badsyn);
@@ -6103,7 +6102,6 @@ rack_do_lastack(struct mbuf *m, struct tcphdr *th, str
 		return (ret_val);
 	}
 	if (ourfinisacked) {
-
 		INP_INFO_RLOCK_ASSERT(&V_tcbinfo);
 		tp = tcp_close(tp);
 		rack_do_drop(m, tp);

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201807182249.w6IMns6D076446>