From owner-svn-src-all@freebsd.org Tue Jul 14 22:14:16 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3C6943513C1; Tue, 14 Jul 2020 22:14:16 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: from mail-yb1-f196.google.com (mail-yb1-f196.google.com [209.85.219.196]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B5vtv6KWSz48Qp; Tue, 14 Jul 2020 22:14:15 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: by mail-yb1-f196.google.com with SMTP id c14so188036ybj.0; Tue, 14 Jul 2020 15:14:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9qvpKf/DhfMwqMWWd6vCk05RrFsa3BlKIs2sHc7t9Yc=; b=VR+1JP/7mLlaG1MBPFHSJeZsjMVh7IScdT0zvl1XxT8MiIUdW4Z8xmhXFKwCUbYqml GsFjoMQ3WJ3fP1GHX/Z29oIDsHJJefUqVEgQAT6olzY+GSYVJeQjKfV1hEkYDSNSqRZq hQ9jbcIlMBJwr6ie70siuODklntrJL+de58WTqX5Ulr7r9kHSJgfc2IoemBIcrmGMSd4 mJgQLBBlufVPeLbwf+j+QwxuAaoE2UrsM7uGt5CbKMT1EgTXWvmK3GM9oyeQ3h5jP+Ug f/MSTCgetu2pzAbLfEpxvZ4HKDX3qhjQ8OhRdJEz+rnjmztVMfwumsXZQZv/K7BkmVN/ nknA== X-Gm-Message-State: AOAM533ktCX1F7junBjkwBJuTbPY+Zsw+wDdEG6qb4s3lPiIuYWVKWmK VJQumfiw3At8jjJ0AsrpqwuLOB2NySQ2TPFae9y4n4cSckI= X-Google-Smtp-Source: ABdhPJwy/icWi5G4pLJQ95wM+hAM7X/LP2hwNaNv+Nw4MO0zfzOOtDgjoFVJ/WVaTAEygrqIkg70otW/MsyEF+ygW4w= X-Received: by 2002:a25:b1a5:: with SMTP id h37mr732360ybj.241.1594764853780; Tue, 14 Jul 2020 15:14:13 -0700 (PDT) MIME-Version: 1.0 References: <202007140154.06E1sOjN003426@repo.freebsd.org> In-Reply-To: <202007140154.06E1sOjN003426@repo.freebsd.org> From: Li-Wen Hsu Date: Wed, 15 Jul 2020 06:14:02 +0800 Message-ID: Subject: Re: svn commit: r363170 - in head: contrib/byacc contrib/byacc/package contrib/byacc/package/debian contrib/byacc/package/pkgsrc contrib/byacc/test contrib/byacc/test/btyacc contrib/byacc/test/yacc usr... To: Jung-uk Kim Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4B5vtv6KWSz48Qp X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jul 2020 22:14:16 -0000 On Tue, Jul 14, 2020 at 9:54 AM Jung-uk Kim wrote: > > Author: jkim > Date: Tue Jul 14 01:54:24 2020 > New Revision: 363170 > URL: https://svnweb.freebsd.org/changeset/base/363170 > > Log: > MFV: r362513 > > Update byacc to 20200330. Hello Jung-uk, There are some things I haven't figured out, but currently there is one yacc test case in our CI is failing. Please check the output of usr.bin.yacc.yacc_tests.main at https://ci.freebsd.org/job/FreeBSD-head-amd64-test/15843/testReport/junit/usr.bin.yacc/yacc_tests/main/ The yacc processed result of /usr/tests/usr.bin/yacc/calc.y is different than the reference, /usr/tests/usr.bin/yacc/yacc/calc.tab.c And checking the files under contrib/byacc/ , there are (1) ./test/calc.tab.c (2) ./test/btyacc/calc.tab.c (3) ./test/yacc/calc.tab.c (3) is what we want, and that was the source of /usr/tests/usr.bin/yacc/yacc/calc.tab.c before this import. It was updated in the new byacc release and matches the behavior of new yacc. However, currently we install (1) as /usr/tests/usr.bin/yacc/calc.y , the content looks generated by a very old yacc The thing I still don't know is why the source of calc.tab.c is changed as there is no related change in usr.bin/yacc/tests/Makefile . Surprisingly, removing (1) can restore the old behavior of using (3) as the source. I haven't checked why that file appears in the upstream distfile but it did not exist in our old version of byacc, 20170201. I'm not sure what's the best way to fix this. The fastest way is just removing contrib/byacc/test/calc.tab.c , and the following task is checking with upstream for the intention of adding that file. We may also want to fix the Makefile or .mk files to make the source of /usr/tests/usr.bin/yacc/yacc/calc.tab.c not affected by the file with the same name under different directories. BTW, there are some entries need to be added to the ObsoleteFiles.inc, like /usr/tests/usr.bin/yacc/err_inherit1.y which is Please help check this test issue of the new yacc. Thanks, Li-Wen