From owner-freebsd-bugs@FreeBSD.ORG Tue Mar 25 16:20:01 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D811B1065674 for ; Tue, 25 Mar 2008 16:20:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id C2D898FC18 for ; Tue, 25 Mar 2008 16:20:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m2PGK1YI067654 for ; Tue, 25 Mar 2008 16:20:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m2PGK1ZI067653; Tue, 25 Mar 2008 16:20:01 GMT (envelope-from gnats) Resent-Date: Tue, 25 Mar 2008 16:20:01 GMT Resent-Message-Id: <200803251620.m2PGK1ZI067653@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Steven Kreuzer Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2D30F1065670 for ; Tue, 25 Mar 2008 16:16:30 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 29C208FC29 for ; Tue, 25 Mar 2008 16:16:30 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m2PGGHJc020963 for ; Tue, 25 Mar 2008 16:16:17 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.2/8.14.1/Submit) id m2PGGHuG020962; Tue, 25 Mar 2008 16:16:17 GMT (envelope-from nobody) Message-Id: <200803251616.m2PGGHuG020962@www.freebsd.org> Date: Tue, 25 Mar 2008 16:16:17 GMT From: Steven Kreuzer To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: bin/122070: Zero out pw_passwd in crontab X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Mar 2008 16:20:01 -0000 >Number: 122070 >Category: bin >Synopsis: Zero out pw_passwd in crontab >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Tue Mar 25 16:20:01 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Steven Kreuzer >Release: 7.0-BETA4 >Organization: >Environment: FreeBSD 7.0-BETA4 FreeBSD 7.0-BETA4 #0: Sun Dec 2 19:19:04 UTC 2007 root@logan.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386 >Description: For the sake of being paranoid, the following patch will zero out pw_passwd since its not needed. >How-To-Repeat: >Fix: Patch attached with submission follows: Index: crontab.c =================================================================== RCS file: /usr/share/cvs/freebsd/src/usr.sbin/cron/crontab/crontab.c,v retrieving revision 1.25 diff -u -r1.25 crontab.c --- crontab.c 7 Nov 2007 10:53:34 -0000 1.25 +++ crontab.c 19 Feb 2008 23:23:11 -0000 @@ -138,6 +138,7 @@ if (!(pw = getpwuid(getuid()))) errx(ERROR_EXIT, "your UID isn't in the passwd file, bailing out"); + bzero(pw->pw_passwd, strlen(pw->pw_passwd)); (void) strncpy(User, pw->pw_name, (sizeof User)-1); User[(sizeof User)-1] = '\0'; strcpy(RealUser, User); @@ -154,6 +155,7 @@ errx(ERROR_EXIT, "must be privileged to use -u"); if (!(pw = getpwnam(optarg))) errx(ERROR_EXIT, "user `%s' unknown", optarg); + bzero(pw->pw_passwd, strlen(pw->pw_passwd)); (void) strncpy(User, pw->pw_name, (sizeof User)-1); User[(sizeof User)-1] = '\0'; break; >Release-Note: >Audit-Trail: >Unformatted: