From owner-freebsd-current Fri Aug 31 18:36:33 2001 Delivered-To: freebsd-current@freebsd.org Received: from taifun.devconsult.de (taifun.devconsult.de [212.15.193.29]) by hub.freebsd.org (Postfix) with ESMTP id CC42437B401 for ; Fri, 31 Aug 2001 18:36:29 -0700 (PDT) Received: from devcon.net (sec-01.bi.devcon.net [212.15.193.30]) by taifun.devconsult.de (8.9.3/8.9.3/il20000124) with SMTP id DAA04944 for ; Sat, 1 Sep 2001 03:36:28 +0200 Received: (qmail 8549 invoked by uid 501); 1 Sep 2001 01:36:28 -0000 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 1 Sep 2001 01:36:28 -0000 Date: Sat, 1 Sep 2001 03:36:28 +0200 (CEST) From: Christian Carstensen To: Subject: dynamic sysctl problem and hot fix Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG hi, i just came across a problem with dynamic sysctls: when unloading a driver module that used dyn sysctls, my system paniced with "oid too high". that problem is caused by sysctl_ctx_free() in kern/kern_sysctl.c, that first deregisters all oids in the list to see if a error occurs. then, all oids are being reregistered and, if there was no error, they're finally removed. during the second phase, sysctl_register_oid(e1->entry) is called with n := e1->entry->oid_number being the old oid number with n > CTL_AUTO_START. that leads to panic("static sysctl too high") in sysctl_register_oid. one approach might be to initialize the oid_number field to contain the value OID_AUTO before calling sysctl_regiser_oid, but i'm unsure about the side effects of doing that in sysctl_ctx_free(). alternatively, the "old" oid number could be reused, the following patch should do, but it's just a workaround. best, christian -- "Sorry, no defects found. Please try a different search" [http://www.cisco.com/support/bugtools/bugtool.shtml] Index: kern_sysctl.c =================================================================== RCS file: /usr/cvs/src/sys/kern/kern_sysctl.c,v retrieving revision 1.113 diff -r1.113 kern_sysctl.c 83a84,96 > static struct sysctl_oid * > sysctl_find_oidnumber(const int number, struct sysctl_oid_list *list) > { > struct sysctl_oid *oidp; > > SLIST_FOREACH(oidp, list, oid_link) { > if (oidp->oid_number == number) { > return (oidp); > } > } > return (NULL); > } > 125c138,139 < panic("static sysctl oid too high: %d", oidp->oid_number); --- > if (sysctl_find_oidnumber(oidp->oid_number, parent)) > panic("static sysctl oid too high: %d", oidp->oid_number); 177c191 < if (error) --- > if (error) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message