From owner-cvs-src@FreeBSD.ORG Mon Feb 9 07:31:35 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 335DB16A4CF; Mon, 9 Feb 2004 07:31:35 -0800 (PST) Received: from sccrmhc12.comcast.net (sccrmhc12.comcast.net [204.127.202.56]) by mx1.FreeBSD.org (Postfix) with ESMTP id C244043D2F; Mon, 9 Feb 2004 07:31:34 -0800 (PST) (envelope-from cristjc@comcast.net) Received: from blossom.cjclark.org (c-24-6-186-224.client.comcast.net[24.6.186.224]) by comcast.net (sccrmhc12) with ESMTP id <20040209153133012007v66he>; Mon, 9 Feb 2004 15:31:33 +0000 Received: from blossom.cjclark.org (localhost. [127.0.0.1]) by blossom.cjclark.org (8.12.9p2/8.12.8) with ESMTP id i19FVV43090792; Mon, 9 Feb 2004 07:31:31 -0800 (PST) (envelope-from cristjc@comcast.net) Received: (from cjc@localhost) by blossom.cjclark.org (8.12.9p2/8.12.9/Submit) id i19FVVv0090791; Mon, 9 Feb 2004 07:31:31 -0800 (PST) (envelope-from cristjc@comcast.net) X-Authentication-Warning: blossom.cjclark.org: cjc set sender to cristjc@comcast.net using -f Date: Mon, 9 Feb 2004 07:31:30 -0800 From: "Crist J. Clark" To: Hajimu UMEMOTO Message-ID: <20040209153130.GA90540@blossom.cjclark.org> References: <200401271557.i0RFvG4b022293@repoman.freebsd.org> <20040209053427.GA47595@blossom.cjclark.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-URL: http://people.freebsd.org/~cjc/ cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet6 in6_pcb.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: cjclark@alum.mit.edu List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Feb 2004 15:31:35 -0000 On Mon, Feb 09, 2004 at 03:59:05PM +0900, Hajimu UMEMOTO wrote: > Hi, > > >>>>> On Sun, 8 Feb 2004 21:34:27 -0800 > >>>>> "Crist J. Clark" said: > > cristjc> On Tue, Jan 27, 2004 at 07:57:16AM -0800, Hajimu UMEMOTO wrote: > > ume 2004/01/27 07:57:16 PST > > > > FreeBSD src repository > > > > Modified files: (Branch: RELENG_5_2) > > sys/netinet6 in6_pcb.c > > Log: > > MFC 1.47: call ipsec_pcbconn()/ipsec_pcbdisconn() from in6_pcbconnect(). > > > > Approved by: re (scott) > > > > Revision Changes Path > > 1.45.2.1 +7 -0 src/sys/netinet6/in6_pcb.c > > cristjc> FWIW, this prevents an INET6 kernel from building without IPSEC. Of > cristjc> course, since IPsec is required in IPv6, this may not be a > cristjc> bug. > > The part where IPSEC is required is enclosed with #ifdef IPSEC. So, I > cannot believe that it breaks building without IPSEC. Please show me > the error message? Sorry, there is another dependency. You must have FAST_IPSEC defined instead of IPSEC. The errors are, /usr/src/sys/netinet6/in6_pcb.c: In function `in6_pcbconnect': /usr/src/sys/netinet6/in6_pcb.c:410: warning: implicit declaration of function `ipsec_pcbconn' /usr/src/sys/netinet6/in6_pcb.c: In function `in6_pcbdisconnect': /usr/src/sys/netinet6/in6_pcb.c:425: warning: implicit declaration of function `ipsec_pcbdisconn' The preprocessor directives at the top set IPSEC when FAST_IPSEC is true. So to rephrase, you cannot build INET6 and FAST_IPSEC (which only does IPv4 IPsec) in the same kernel. -- Crist J. Clark | cjclark@alum.mit.edu | cjclark@jhu.edu http://people.freebsd.org/~cjc/ | cjc@freebsd.org