From owner-freebsd-threads@freebsd.org Wed Oct 25 15:34:16 2017 Return-Path: Delivered-To: freebsd-threads@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 62808E4DBBF for ; Wed, 25 Oct 2017 15:34:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 509E872CA1 for ; Wed, 25 Oct 2017 15:34:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v9PFYEQV057206 for ; Wed, 25 Oct 2017 15:34:16 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-threads@FreeBSD.org Subject: [Bug 223165] Crash with pthread_condattr_destroy(NULL) on freebsd-11 Date: Wed, 25 Oct 2017 15:34:15 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: markj@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-threads@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-threads@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Threading on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2017 15:34:16 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D223165 Mark Johnston changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |markj@FreeBSD.org --- Comment #3 from Mark Johnston --- clang will in some cases optimize away null checks of parameters qualified = with _Nonnull. It doesn't seem to have done that in a libthr built with clang 5.= 0: 0000000000008cf0 <_pthread_condattr_destroy>: 8cf0: 55 push %rbp 8cf1: 48 89 e5 mov %rsp,%rbp 8cf4: 53 push %rbx 8cf5: 50 push %rax 8cf6: 48 89 fb mov %rdi,%rbx 8cf9: b8 16 00 00 00 mov $0x16,%eax 8cfe: 48 85 db test %rbx,%rbx 8d01: 74 16 je 8d19 <_pthread_condattr_destroy+0x29> ... ... but I've seen it do that a number of times in Isilon OneFS. With 3.9.1 = we have: 0000000000008de0 <_pthread_condattr_destroy>: 8de0: 55 push %rbp 8de1: 48 89 e5 mov %rsp,%rbp 8de4: 53 push %rbx 8de5: 50 push %rax 8de6: 48 89 fb mov %rdi,%rbx 8de9: 48 8b 3b mov (%rbx),%rdi 8dec: b8 16 00 00 00 mov $0x16,%eax 8df1: 48 85 ff test %rdi,%rdi ... I don't think that there's a bug here in light of comment 2. --=20 You are receiving this mail because: You are the assignee for the bug.=