From owner-svn-ports-all@FreeBSD.ORG  Mon Jan 13 08:35:14 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id BF831D3F;
 Mon, 13 Jan 2014 08:35:14 +0000 (UTC)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 932B51112;
 Mon, 13 Jan 2014 08:35:14 +0000 (UTC)
Received: from [192.168.0.21] (unknown [130.255.19.191])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id 497FF43B8C;
 Mon, 13 Jan 2014 02:34:56 -0600 (CST)
Message-ID: <52D3A51F.8080709@marino.st>
Date: Mon, 13 Jan 2014 09:34:39 +0100
From: John Marino <freebsd.contact@marino.st>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:17.0) Gecko/20130509 Thunderbird/17.0.6
MIME-Version: 1.0
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Subject: Re: svn commit: r338361 - in head/devel/silentbob: . files
References: <201401010649.s016nJ4w004860@svn.freebsd.org>
 <20140113082949.GB8735@FreeBSD.org>
In-Reply-To: <20140113082949.GB8735@FreeBSD.org>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org, TAKATSU Tomonari <tota@FreeBSD.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
Reply-To: marino@freebsd.org
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jan 2014 08:35:14 -0000

On 1/13/2014 09:29, Alexey Dokuchaev wrote:
> On Wed, Jan 01, 2014 at 06:49:19AM +0000, TAKATSU Tomonari wrote:
>> New Revision: 338361
>> URL: http://svnweb.freebsd.org/changeset/ports/338361
>>
>> +PORTDOCS=	README
> [...]
>> +.if ${PORT_OPTIONS:MDOCS}
>>  post-install:
>> -.if !defined(NOPORTDOCS)
>> -	@${MKDIR} ${DOCSDIR}
>> -	@${INSTALL_DATA} ${WRKSRC}/README ${DOCSDIR}
>> -	@${INSTALL_DATA} ${WRKSRC}/doc/* ${DOCSDIR}
>> +	@${MKDIR} ${STAGEDIR}${DOCSDIR}
>> +	@${INSTALL_DATA} ${WRKSRC}/${PORTDOCS} ${STAGEDIR}${DOCSDIR}
> 
> For a simple cases like this one (when docs are not being built and are just
> a lonely README file), once staged, .if ${PORT_OPTIONS:MDOCS} is no longer
> necessary (and would allow you to remove .include <bsd.port.options.mk>).
> 
> Please note that INSTALL_* commands should not be muted (muting MKDIR is
> fine), thank you.

On the latter, maybe it would be worth your time to modify portlint to
flag muted install commands in the install and post-install targets?
stage targets too.