From nobody Mon Feb 6 01:43:26 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P98DG73Fgz3n5DZ for ; Mon, 6 Feb 2023 01:43:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P98DG4W6Wz44JN for ; Mon, 6 Feb 2023 01:43:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675647806; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D48cfwG3v5Oq7DGzRusR1uJShcbqlRJVEbE9S7lv6TI=; b=m+sx80o156yKAeDo0q1rR/i7SPj31vpkmad1JzsNtls5HqPAARnTqwz9JVgorE/yjtlkYh lmiXIB/KHQhDpoVxb1Gz5CAH51/E7b7KQkzHRhRfDwaLp98vPOqBuf4x38N8Jw9nB4h3UH 5VSGQdYUF0EwG4QBpI3Jvz1620Vg0/uGvUc6zwValhi9SilwSz+speQtp3OMvF4wED3WCr nDtwQT+p7LCX4TNPoKZIW4cxr9Bq+mnxG9g+kL9JFciHj6Wwe3XSZ03Ys3ZZdQYoplEnOm 9K7/1juLjNKjVPMZTFtBTpqefQ1RdxEyJViM3uNC9qIvTP7+wLY/WX6yHD8mmQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1675647806; a=rsa-sha256; cv=none; b=ifqGDUt/r5npx0wFI+1Mww4MPdto4NfFkALiWrVLHiGSRH4gtcaMrhPfnd2/Awx9X+oA9I BRJoA58WJUyGI59z7G1DhlOri64UuHfvvMEmn6RzON/EnaYeYe2iHoi57SrNlLCaBQ756N 1u+oBxrdl+j0e4ryY9RfFAWnw/f18XAumrpN/aTBInE1CzpavCehfBieC2K5XRWUQE7+R3 WPj97x6R3l2//YrIpoOIlYONtvPtlvIYddXj4CXmF5886npzLwIwsurEyCBqs5/aL49NoC QYWH2PIT6A6L70F6oVICPBeOlK225dsmTpdFPS+Vwr9Pb3zO6funQuE4VJTWtA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4P98DG3bgHzHGg for ; Mon, 6 Feb 2023 01:43:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3161hQZg030028 for ; Mon, 6 Feb 2023 01:43:26 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3161hQ7r030027 for bugs@FreeBSD.org; Mon, 6 Feb 2023 01:43:26 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 269328] nfs client: data corruption using fspacectl and mmap Date: Mon, 06 Feb 2023 01:43:26 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: rmacklem@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: rmacklem@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D269328 Rick Macklem changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bugs@FreeBSD.org |rmacklem@FreeBSD.org --- Comment #8 from Rick Macklem --- Created attachment 239937 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D239937&action= =3Dedit do a VOP_FSYNC() after vop_stddeallocate() to push writes of 0s This simple patch fixes the case that the test program finds. I am not 100% sure why it does fix this, but the code should always have done this since having the changes committed to the server before VOP_DEALLOCATE() returns is required. Btw, for a newer NFSv4.2 server that supports a Deallocate operation, your test program works. (I hacked my server so that Deallocate was disabled and was able to reproduce the failure with your test program.) Maybe asomers@ can test the patch and see if it fixes all the NFS cases he observes? --=20 You are receiving this mail because: You are the assignee for the bug.=