From owner-freebsd-bugs@FreeBSD.ORG Wed Mar 18 06:10:05 2009 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1B4611065673 for ; Wed, 18 Mar 2009 06:10:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D08558FC12 for ; Wed, 18 Mar 2009 06:10:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n2I6A4at019911 for ; Wed, 18 Mar 2009 06:10:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n2I6A4Kw019908; Wed, 18 Mar 2009 06:10:04 GMT (envelope-from gnats) Resent-Date: Wed, 18 Mar 2009 06:10:04 GMT Resent-Message-Id: <200903180610.n2I6A4Kw019908@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, KOIE Hidetaka Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 477A6106566B for ; Wed, 18 Mar 2009 06:00:39 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 360468FC08 for ; Wed, 18 Mar 2009 06:00:39 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n2I60cXa008505 for ; Wed, 18 Mar 2009 06:00:38 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n2I60ct2008504; Wed, 18 Mar 2009 06:00:38 GMT (envelope-from nobody) Message-Id: <200903180600.n2I60ct2008504@www.freebsd.org> Date: Wed, 18 Mar 2009 06:00:38 GMT From: KOIE Hidetaka To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: misc/132766: wait_for_pids() in /etc/rc.subr is dull. X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Mar 2009 06:10:05 -0000 >Number: 132766 >Category: misc >Synopsis: wait_for_pids() in /etc/rc.subr is dull. >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Mar 18 06:10:04 UTC 2009 >Closed-Date: >Last-Modified: >Originator: KOIE Hidetaka >Release: CURRENT >Organization: surigiken >Environment: FreeBSD guriandgura 8.0-CURRENT FreeBSD 8.0-CURRENT #0: Thu Feb 5 04:32:41 JST 2009 koie@guriandgura:/usr/obj/usr/src/sys/GURIANDGURA amd64 >Description: wait_for_pids() in /etc/rc.subr uses sleep 2 to wait. but, daemons usually exit before within 2 seconds in my environment. I propose short sleep. >How-To-Repeat: >Fix: Patch attached with submission follows: --- /usr/src/etc/rc.subr 2008-11-01 09:21:29.578401768 +0900 +++ /etc/rc.subr 2009-03-10 18:26:12.000000000 +0900 @@ -351,7 +351,9 @@ wait_for_pids() return fi _prefix= + _slp_list=0.5 while true; do + for _slp in $_slp_list; do _nlist=""; for _j in $_list; do if kill -0 $_j 2>/dev/null; then @@ -362,9 +364,14 @@ wait_for_pids() break fi _list=$_nlist + sleep $_slp + done + if [ -z "$_nlist" ]; then + break + fi echo -n ${_prefix:-"Waiting for PIDS: "}$_list _prefix=", " - sleep 2 + _slp_list="0.2 0.4 0.6 0.8" done if [ -n "$_prefix" ]; then echo "." >Release-Note: >Audit-Trail: >Unformatted: