From nobody Fri Jan 17 18:46:58 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YZTH63hWzz5lKQB; Fri, 17 Jan 2025 18:46:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YZTH62cwGz3lgy; Fri, 17 Jan 2025 18:46:58 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737139618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iLROnbokmy+ZHD0Yz4SgfDSXxiPhgtieK3EF0yNgucg=; b=vPJinWixm0vHWpf7FIlhqdluJVa66E7Sf8neXEC+IS+hPX9jQusBOOwzH4Mk/eXUUGu8Zw DCHH7Ef8DeuvFyD3auTphkFkRjRNOrada2LgX+g7LlWhSmgizBG90wtiTQwH9G0Ia9BKX4 LBSYgUvFVJKitnaymv2bAUmaiJjdLh+w4aVAJh2f4HaYfJDGnvH6BLC2CKW7RcN3EVtIqx BSIrdz14tqmygrWhUtWkHcq7Gid8kNDrSlIVlwQH2tnLHheNzYXQINeLnNr9guqcHEaakG P6/K1zV6GF2r8utLHOLS4fKwpmFerucdPm69Iic7aA8XPcfwQ5IIn7qUc6YYIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737139618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iLROnbokmy+ZHD0Yz4SgfDSXxiPhgtieK3EF0yNgucg=; b=qRKr+fiwh61H+SBuNH+w62wNP/YAZiptia+K6BAIqfGpgYOUncZyJScHGoOWo64JhmARf6 5xwK6iRQtMbxbLNtRWd2kuh63LBQ4joCgUnZmXBG7sC84NuZfOey7Yll4yh46kB/EGFO2o pHuiy1Ov6aQg+mO2B1W5rSeGeZQ/c85Nu57aTO7XCCZ09DGkPZYs2ibAX7+zvc/qh/SrHv kAw8WuiFPTq/Rp2tIT1NnfmJJMb8oLjsVbopsInAsazTrvxLCCrILxdrLuC1eKjn1yV7rK w1pS2BxguOHLhXT6Kj2nGlYUEK9FtZEOkPVbJOM7BjZDHD3zAKlraO8pYK3tqw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1737139618; a=rsa-sha256; cv=none; b=d17JyLXFEY3Vfm+S5EDe1A0uHDbZDMW7UEDqEIuyaWYMF+9KFSApICOExPh1zdjDdQ6keI 3bsfIgNiK0jHyKSl3vRRERZq5S41bsq0pc4M9j03BNMR9OwodVeu21zOKWGqO30YdqGv++ ByfkoWBjs1HhgY+wbf8HJJuWD8i7A35xSekGa74WVIVuBgfzJrLisFXb2ipljsStThSrTv 5BVEyVPLHV9HKRC/sJQInYnATvJiGNmDY1vHJj8z5KCZcKaR0BNRSImLuaL88iJY7OguXN XmVDQAi8tcYkpUZKTKTLv6Bh+/6IXVkgaLLiwd2ahDT9iUvPaIl65AQZM//tQg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YZTH62BW6zVVh; Fri, 17 Jan 2025 18:46:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 50HIkwQO061211; Fri, 17 Jan 2025 18:46:58 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 50HIkweD061208; Fri, 17 Jan 2025 18:46:58 GMT (envelope-from git) Date: Fri, 17 Jan 2025 18:46:58 GMT Message-Id: <202501171846.50HIkweD061208@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: e6025bc05cda - stable/14 - Fix "vrefact: wrong use count 0" with DRM List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: e6025bc05cda3a33ac9e9d9e1b0a5677956f0d47 Auto-Submitted: auto-generated The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=e6025bc05cda3a33ac9e9d9e1b0a5677956f0d47 commit e6025bc05cda3a33ac9e9d9e1b0a5677956f0d47 Author: Edward Tomasz Napierala AuthorDate: 2024-11-13 10:00:38 +0000 Commit: Mark Johnston CommitDate: 2025-01-17 18:43:42 +0000 Fix "vrefact: wrong use count 0" with DRM Bump the vnode use count, not its hold count. This fixes a panic triggered by fstatat(..., AT_EMPTY_PATH) on DRM device nodes, which happens to be what glxinfo(1) from Ubuntu Jammy is doing. PR: kern/274538 Reviewed By: kib (earlier version), olce Differential Revision: https://reviews.freebsd.org/D47391 (cherry picked from commit fc595a6b76642dfdfdb8e6f9b9bbc734e95fb59c) --- sys/compat/linuxkpi/common/src/linux_compat.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/compat/linuxkpi/common/src/linux_compat.c b/sys/compat/linuxkpi/common/src/linux_compat.c index 1fc71c55469a..b60f464377cc 100644 --- a/sys/compat/linuxkpi/common/src/linux_compat.c +++ b/sys/compat/linuxkpi/common/src/linux_compat.c @@ -773,7 +773,7 @@ linux_dev_fdopen(struct cdev *dev, int fflags, struct thread *td, } /* hold on to the vnode - used for fstat() */ - vhold(filp->f_vnode); + vref(filp->f_vnode); /* release the file from devfs */ finit(file, filp->f_mode, DTYPE_DEV, filp, &linuxfileops); @@ -1505,7 +1505,7 @@ linux_file_close(struct file *file, struct thread *td) error = -OPW(file, td, release(filp->f_vnode, filp)); funsetown(&filp->f_sigio); if (filp->f_vnode != NULL) - vdrop(filp->f_vnode); + vrele(filp->f_vnode); linux_drop_fop(ldev); ldev = filp->f_cdev; if (ldev != NULL)