From owner-svn-src-head@freebsd.org Tue May 3 20:29:15 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 974EBB2CD1A for ; Tue, 3 May 2016 20:29:15 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mail-io0-x229.google.com (mail-io0-x229.google.com [IPv6:2607:f8b0:4001:c06::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5CBCF148F for ; Tue, 3 May 2016 20:29:15 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: by mail-io0-x229.google.com with SMTP id u185so39615634iod.3 for ; Tue, 03 May 2016 13:29:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=sender:subject:mime-version:from:in-reply-to:date:cc:message-id :references:to; bh=FEfc2Zfku7M3jxiqVVth1/5/NIRJXWkoI0IrJkkXUHY=; b=WWueuUyaZqza1wMTJKE7n39v9RXpFHqhBljoud79A1zyOQPvp7TqK4mJc04+mJcs2j 9mml+s0+k3Z1w8l1vn8+Vx/e3Y0Uvn0IXVX2bxfJPg4WKBzvLas+87yQFmU+VkxLwjYn tEIrmxKHJmohlwWuvOK4pyWCEwRw0iCXOPGYMUPYOUT8as6NeBgexMcEO4yaLa9IsDaq rvobx81xAoIEdb5yrouzs26NfeBUs5pq0A65pAZgQlIdzRnMO2Mb+FPJWLXZ3r7ZEuwf UrWXbQrBQBJKIPpxkpyi4DdXRpEiRQG0dq+WcYvGaJ5O7wbGjYtCJ0cx0OFN5Hqs0tyQ wBvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:from:in-reply-to :date:cc:message-id:references:to; bh=FEfc2Zfku7M3jxiqVVth1/5/NIRJXWkoI0IrJkkXUHY=; b=QSRE2lBf++nRHLgY+tkepN2fkCAbilzT/XxeKFoKzlWSThZWsWqyuhyPFmUUNMgL/d eTFbBcUV9/SIjydWmZL4x0tHJXZ3FY0M8dpUDBdVYk9GrTFdQ6MYVaZqolyZTpQOrR79 o6nOqVLKdz2XuOOOHzp2SrgEu3ojI31IsDnwj9njx7iMM3593WUCHWYblJPyNcRZdCR+ dy8puP1061B9OA2on/FIc21p0Q4IIjvt+ZuhMIncWeFmW5RfzsKlf78aWy0vgTXimVAJ FXuEtF5+SCC/xLrUA+ZHv4V6A+60vlUZxEZD377HwQ94N1NV2LGqAo4SF+SbZQCbUphK 8ldA== X-Gm-Message-State: AOPr4FWpteWFGCKLLM+7HvC72TciNgH36D7FKqPWLuyUWs4fF8sWkI1lYnj7tcozkzYo0g== X-Received: by 10.107.134.195 with SMTP id q64mr5945583ioi.25.1462307354444; Tue, 03 May 2016 13:29:14 -0700 (PDT) Received: from mac-wired.nflx.bsdimp.com ([50.253.99.174]) by smtp.gmail.com with ESMTPSA id i14sm98494iod.34.2016.05.03.13.29.13 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 03 May 2016 13:29:13 -0700 (PDT) Sender: Warner Losh Subject: Re: svn commit: r298665 - head/sys/dev/aacraid Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Content-Type: multipart/signed; boundary="Apple-Mail=_E1A310D5-E2E5-4A5C-BC80-4BEA56058EDA"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5.2 From: Warner Losh In-Reply-To: Date: Tue, 3 May 2016 14:29:09 -0600 Cc: Oliver Pinter , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: References: <201604262059.u3QKxLDl045059@repo.freebsd.org> To: cem@FreeBSD.org X-Mailer: Apple Mail (2.2104) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2016 20:29:15 -0000 --Apple-Mail=_E1A310D5-E2E5-4A5C-BC80-4BEA56058EDA Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On May 3, 2016, at 1:44 PM, Conrad Meyer wrote: >=20 > On Tue, May 3, 2016 at 12:00 PM, Oliver Pinter > wrote: >> strlcpy instead or adjust the p->vendors size? >=20 > Neither. The buffer is intentionally not nul-terminated. The > coverity reports are false positives. Then wouldn=E2=80=99t memcmp be better? Warner --Apple-Mail=_E1A310D5-E2E5-4A5C-BC80-4BEA56058EDA Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJXKQoVAAoJEGwc0Sh9sBEAStgQAM8Gx4YYrJiIRBfXfgQdg+/T /gQGH5nQZ52BD8G9qdZ0qHL9yahhQ3kg+X5qJ3+9d+VXclhHiFRSF2/56h1OXxPL RiTsO1L3zt9yYcsyMtHeNXnLFty5HUIwmgPV1hkT+gmgCLFcrin98Qy+DwVvq+Fp NqB47EBFTGiXyht8KoEwWOJNcVAKPgzrrpyCupGjrTw86qZMbz+3n5MrVVjg3cRk a00vkcYA8gpk2IeF/bjXtyLRFMzwrq7NiO84WCxqyOkq1LjHBLX7InTJ6xYJCBK/ pJu2LFvblDG3nB025HGjScW+8d1zsjyMTnsRVbsa5ja7vVYMjOPleQFCVMsGav8f n9PWu+XKMsiNgszm/PjxQzQm9H6wx8QtxVB1V5L3/NZiSFBHZT1GOoaalLvW9KvU eH6EbnTomGgPsHVC7gdNeDwCI/qJo7U7iCwgLcbj+9tLulijayueWodGbm2zXyDn W1yStn7SMRR3lB3kY2FC1GnBqa/2vmsEfKxPr0HZATUnoVVv1bwOa2dGThmC9lQ3 ULCJz7s8n9ELMcgaeMIyVf9P79kCDqMC0Mp8MEPXvUMPL5XiMh5fVBc/wRIg8BI5 KEMEcnba9qgSlqlWJ7LGdc8sKYMj4aG9ca5VJnLLKBUw22kVFEz5TAIADeg+UPfw /Z8xFhCCx4rZVSqC4cgW =EMtG -----END PGP SIGNATURE----- --Apple-Mail=_E1A310D5-E2E5-4A5C-BC80-4BEA56058EDA--