From owner-freebsd-current@freebsd.org Fri Apr 2 04:56:20 2021 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CEAB25C11C3; Fri, 2 Apr 2021 04:56:20 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FBSSN5RSjz3nSg; Fri, 2 Apr 2021 04:56:20 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-qt1-f171.google.com with SMTP id c6so3136491qtc.1; Thu, 01 Apr 2021 21:56:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=NyC5xzo7Oco9Eys23fR/yABVMUbdN97rdnUbPI+wZZY=; b=bAWPjWiH24EEcmKYI9oTTj10/0TDPsy+VLzV49OCGznhCxGuwcqcfhrbw12KoAj66r zts8pVcErguICj+q+97XYpBSDfkQloCmrSo5TIejn6Ku96oVmIZmG8WES0SG7W0oNC9j bLH8dCW1MOws1X4tRnGbOMDAaaM1e7J489McqmX9hQRuqCvLcxy89ZHq0rpDZ7ZBcJ+b n32xfMXGZh3b7kDByjNL64r3791PnRvYhhKfDeCEZrpX3CJZQmK0UsZNwGSzrOh/Fzn8 J6ZzQ8YTQVnpdMi5XDMGVYaL8q48a8F9k5ELxUoio75PYMRDzN09e9VRLR2DI9L+FfgQ l8dw== X-Gm-Message-State: AOAM531VfTQ3AP5mKzIvsmCpz00OkG5HS+mkEPITlJBSuzf+14SRdLSB QmRawSO0kH/E/ea73502gLJIeB5uZhhUrZ80Ulc= X-Google-Smtp-Source: ABdhPJzdWrzpzNj0qDjkEWmluMdfDoYpeO+CYu7WfampDVMy64KRH9jpgVD3AddYGP2Z4YjswyaUaQBcD0ZcnlTE1FM= X-Received: by 2002:ac8:7fc1:: with SMTP id b1mr10190357qtk.363.1617339379736; Thu, 01 Apr 2021 21:56:19 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Adrian Chadd Date: Thu, 1 Apr 2021 21:56:07 -0700 Message-ID: Subject: Re: Correct net80211 channel flag. To: qcwap <1051244836@qq.com> Cc: freebsd-wireless , freebsd-current Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4FBSSN5RSjz3nSg X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Apr 2021 04:56:20 -0000 Hi! Oh, so from what I recall, implementations got it wrong in the early draft days with their interop so the flag values changed. -adrian On Thu, 1 Apr 2021 at 20:45, qcwap <1051244836@qq.com> wrote: > > Well, I see. > > I am newly to freebsd, thanks for your answering. > I had tried using this section of code and found these flags are not sati= sfied, after changing them, I can negotiate VHT80, VHT160 fine with iwm, so= I pointed out this problem. I am also wondering what's the badly wrong of = you said in draft VHT implementation? > > thanks > zxystd > > > 2021=E5=B9=B43=E6=9C=8830=E6=97=A5 =E4=B8=8A=E5=8D=881:26=EF=BC=8CAdria= n Chadd =E5=86=99=E9=81=93=EF=BC=9A > > > > hm! > > > > On Mon, 29 Mar 2021 at 08:02, qcwap <1051244836@qq.com> wrote: > >> > >> This patch corrects ieee80211_vht_get_vhtcap_ie for 160/80P80 channel = width recognition. > >> > >> diff --git a/sys/net80211/ieee80211.h b/sys/net80211/ieee80211.h > >> index 86ab1459cca..76c43629b33 100644 > >> --- a/sys/net80211/ieee80211.h > >> +++ b/sys/net80211/ieee80211.h > >> @@ -811,9 +811,9 @@ struct ieee80211_ie_vht_operation { > >> #define IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_MASK 0x0000000C > >> #define IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_MASK_S 2 > >> #define IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_NONE 0 > >> -#define IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_160MHZ 1 > >> -#define IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_160_80P80MHZ 2 > >> -#define IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_RESERVED 3 > >> +#define IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_160MHZ 4 > >> +#define IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_160_80P80MHZ 8 > >> +#define IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_RESERVED 16 > >> > >> #define IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_IS_160MHZ(_vhtcaps) = \ > >> (_IEEE80211_MASKSHIFT(_vhtcaps, IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_M= ASK) >=3D \ > > > > > > This is the flag change from the draft 11ac spec to the released 11ac > > spec, right? > > > > I remember they needed to change the flags because existing draft > > implementations got the 80+80/160MHz negotiation really badly wrong in > > some interop places... > > > > > > -adrian > > > >> > >> _______________________________________________ > >> freebsd-current@freebsd.org mailing list > >> https://lists.freebsd.org/mailman/listinfo/freebsd-current > >> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.= org" > > >