From owner-freebsd-ports Fri Sep 10 1:10:12 1999 Delivered-To: freebsd-ports@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (Postfix) with ESMTP id 5691115975 for ; Fri, 10 Sep 1999 01:10:10 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.9.3/8.9.2) id BAA82732; Fri, 10 Sep 1999 01:10:02 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Date: Fri, 10 Sep 1999 01:10:02 -0700 (PDT) Message-Id: <199909100810.BAA82732@freefall.freebsd.org> To: freebsd-ports@FreeBSD.org Cc: From: Thomas Gellekum Subject: Re: ports/13677: Misc. Ports fix ups. Reply-To: Thomas Gellekum Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org The following reply was made to PR ports/13677; it has been noted by GNATS. From: Thomas Gellekum To: reg@shale.csir.co.za Cc: FreeBSD-gnats-submit@FreeBSD.ORG Subject: Re: ports/13677: Misc. Ports fix ups. Date: 10 Sep 1999 10:02:58 +0200 reg@shale.csir.co.za writes: > Some things... python: this > fixes a problem which I had with threads support in py-gnome. > --- /usr/ports.ref/lang/python/Makefile Tue Aug 31 21:36:12 1999 > +++ lang/python/Makefile Tue Aug 31 22:04:17 1999 > @@ -52,7 +52,7 @@ > LIBC_R!= /sbin/ldconfig -r | grep c_r || true > .if ${LIBC_R} != "" && defined(WITH_THREADS) && ${WITH_THREADS} == yes > CONFIGURE_ARGS+= --with-thread > -CFLAGS+= -D_THREAD_SAFE > +CFLAGS+= -D_THREAD_SAFE -pthread > CONFIGURE_ENV+= LDFLAGS="-pthread ${LDFLAGS}" > .endif Since -pthread is a linker flag, not a compiler flag, I'd prefer: Index: patches/patch-ab =================================================================== RCS file: /home/ncvs/ports/lang/python/patches/patch-ab,v retrieving revision 1.12 diff -u -r1.12 patch-ab --- patch-ab 1999/05/10 16:11:45 1.12 +++ patch-ab 1999/09/10 07:58:20 @@ -1,11 +1,11 @@ ---- configure.orig Mon May 10 23:49:46 1999 -+++ configure Mon May 10 23:50:31 1999 +--- configure.orig Sat Apr 10 18:02:18 1999 ++++ configure Fri Sep 10 09:47:29 1999 @@ -2246,7 +2246,7 @@ fi ;; Linux*) LDSHARED="gcc -shared";; dgux*) LDSHARED="ld -G";; - FreeBSD*/3*) LDSHARED="gcc -shared";; -+ FreeBSD*/3*|FreeBSD*/4*) LDSHARED="gcc -shared";; ++ FreeBSD*/3*|FreeBSD*/4*) LDSHARED='gcc -shared ${LDFLAGS}';; FreeBSD*|OpenBSD*) LDSHARED="ld -Bshareable";; NetBSD*) if [ "`$CC -dM -E -