From owner-freebsd-doc@FreeBSD.ORG Wed Sep 10 08:51:02 2003 Return-Path: Delivered-To: freebsd-doc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 14B9C16A4BF; Wed, 10 Sep 2003 08:51:02 -0700 (PDT) Received: from pittgoth.com (14.zlnp1.xdsl.nauticom.net [209.195.149.111]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7594543FCB; Wed, 10 Sep 2003 08:51:00 -0700 (PDT) (envelope-from trhodes@FreeBSD.org) Received: from localhost (acs-24-154-239-225.zoominternet.net [24.154.239.225]) by pittgoth.com (8.12.9/8.12.9) with SMTP id h8AFoqvd028265; Wed, 10 Sep 2003 11:50:58 -0400 (EDT) (envelope-from trhodes@FreeBSD.org) Date: Wed, 10 Sep 2003 11:08:24 -0400 From: Tom Rhodes To: Christian Brueffer Message-Id: <20030910110824.6caa54e4.trhodes@FreeBSD.org> In-Reply-To: <20030908223058.GD19937@unixpages.org> References: <20030908142254.3592ed0d.trhodes@FreeBSD.org> <20030908223058.GD19937@unixpages.org> X-Mailer: Sylpheed version 0.9.3claws (GTK+ 1.2.10; i386-portbld-freebsd5.1) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit cc: Tom Rhodes cc: FreeBSD-doc@FreeBSD.org Subject: Re: Pre-commit review requested X-BeenThere: freebsd-doc@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Documentation project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Sep 2003 15:51:02 -0000 On Tue, 09 Sep 2003 00:30:59 +0200 Christian Brueffer wrote: > On Mon, Sep 08, 2003 at 02:22:54PM -0400, Tom Rhodes wrote: > > Any -doc committer want to review the following patch. It is by no > > way an in depth cleanup, but it will take us (myself anyway) one > > step further toward my goal of a good security chapter. > > > > This diff: > > > > o Adds , , and other tags as required. > > o Uses the &os; entity. > > o Cleans up the introduction by pointing out what > > version of Kerberos is in what FreeBSD Release. > > o Modifies and title's to help seperate KerberosIV and Kerberos5. > > > > I'm only looking for either objections or "please commit"s and would rather > > not bounce this around for the next three days. Thanks! > > > > [patch] > > Looks good to me. > Yes, it looks good. But there is a problem, it breaks. Notice the unclosed tags which I neglected, but my make lint pre-commit test actually caught that. :) -- Tom Rhodes