From owner-cvs-all@FreeBSD.ORG  Fri Dec  7 07:15:41 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 275F716A417;
	Fri,  7 Dec 2007 07:15:41 +0000 (UTC)
	(envelope-from brde@optusnet.com.au)
Received: from mail12.syd.optusnet.com.au (mail12.syd.optusnet.com.au
	[211.29.132.193])
	by mx1.freebsd.org (Postfix) with ESMTP id 9BAF913C447;
	Fri,  7 Dec 2007 07:15:39 +0000 (UTC)
	(envelope-from brde@optusnet.com.au)
Received: from c211-30-219-213.carlnfd3.nsw.optusnet.com.au
	(c211-30-219-213.carlnfd3.nsw.optusnet.com.au [211.30.219.213])
	by mail12.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id
	lB77FDXD012088
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Fri, 7 Dec 2007 18:15:16 +1100
Date: Fri, 7 Dec 2007 18:15:13 +1100 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@delplex.bde.org
To: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
In-Reply-To: <86odd4chdn.fsf@ds4.des.no>
Message-ID: <20071207181448.P871@delplex.bde.org>
References: <200711192157.lAJLvSu6057416@repoman.freebsd.org>
	<868x4beu46.fsf@ds4.des.no> <20071204115427.D3192@delplex.bde.org>
	<86odd4chdn.fsf@ds4.des.no>
MIME-Version: 1.0
Content-Type: MULTIPART/MIXED; BOUNDARY="0-411707526-1197011713=:871"
Cc: cvs-src@freebsd.org, cvs-all@freebsd.org, src-committers@freebsd.org,
	Olivier Houchard <cognet@freebsd.org>, Bruce Evans <brde@optusnet.com.au>
Subject: Re: cvs commit: src/lib/libc/gen closedir.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Dec 2007 07:15:41 -0000

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--0-411707526-1197011713=:871
Content-Type: TEXT/PLAIN; charset=X-UNKNOWN; format=flowed
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Thu, 6 Dec 2007, [utf-8] Dag-Erling Sm=C3=B8rgrav wrote:

> Bruce Evans <brde@optusnet.com.au> writes:
>> dd_lock cannot be declared as struct pthread_mutex *, since pthread_mute=
x
>> is not permitted in the application namespace of dirent.h.  dirent.h
>> is (was) careful about namespaces.  E.g., it keeps out of the applicatio=
n
>> namespace for its own struct _dirdesc.  This doesn't work for pthread_mu=
tex
>> since that is misdesigned.  (I think pthread_mutex_t is supposed to
>> hide the implementation and reduce namespace problems, but struct
>> pthread was only declared in <pthread.h> where it is permitted in the
>> namespace, so <pthread.h> doesn't bother naming it struct _pthread_mutex=
=2E
>> Other headers can't define it with a different name (tag) because differ=
ent
>> tags give different structs.)
>
> Since struct pthread_mutex is not part of the API, how about simply
> renaming it to struct _pthread_mutex to circumvent the namespace issues?

Seems right in theory.

Bruce
--0-411707526-1197011713=:871--