From owner-freebsd-acpi@FreeBSD.ORG  Tue Nov  2 20:14:15 2010
Return-Path: <owner-freebsd-acpi@FreeBSD.ORG>
Delivered-To: freebsd-acpi@freebsd.org
Received: from [127.0.0.1] (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by hub.freebsd.org (Postfix) with ESMTP id 99718106566B;
	Tue,  2 Nov 2010 20:14:15 +0000 (UTC)
	(envelope-from jkim@FreeBSD.org)
From: Jung-uk Kim <jkim@FreeBSD.org>
To: John Baldwin <jhb@freebsd.org>
Date: Tue, 2 Nov 2010 16:14:05 -0400
User-Agent: KMail/1.6.2
References: <201010121209.06397.hselasky@c2i.net>
	<201011021529.05977.jkim@FreeBSD.org>
	<201011021541.48741.jhb@freebsd.org>
In-Reply-To: <201011021541.48741.jhb@freebsd.org>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201011021614.07631.jkim@FreeBSD.org>
Cc: "Moore, Robert" <robert.moore@intel.com>, freebsd-acpi@freebsd.org,
	Lin Ming <ming.m.lin@intel.com>, Andriy Gapon <avg@freebsd.org>
Subject: Re: MacBookPro 5,1
X-BeenThere: freebsd-acpi@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: ACPI and power management development <freebsd-acpi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-acpi>
List-Post: <mailto:freebsd-acpi@freebsd.org>
List-Help: <mailto:freebsd-acpi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Nov 2010 20:14:15 -0000

On Tuesday 02 November 2010 03:41 pm, John Baldwin wrote:
> On Tuesday, November 02, 2010 3:29:01 pm Jung-uk Kim wrote:
> > On Tuesday 02 November 2010 11:29 am, Andriy Gapon wrote:
> > > on 29/10/2010 08:51 Andriy Gapon said the following:
> > > > I guess that a general problem here is that it is incorrect
> > > > to merely use memcpy/bcopy to create a copy of a resource if
> > > > the resource has ACPI_RESOURCE_SOURCE field in it.
> > >
> > > Hans,
> > >
> > > could you please test the following patch?
> > >
> > > diff --git a/sys/dev/acpica/acpi_pci_link.c
> > > b/sys/dev/acpica/acpi_pci_link.c index dcf101d..e842635 100644
> > > --- a/sys/dev/acpica/acpi_pci_link.c
> > > +++ b/sys/dev/acpica/acpi_pci_link.c
> > > @@ -767,6 +767,8 @@ acpi_pci_link_srs_from_crs
> > >  				    link->l_irq;
> > >  			else
> > >  				resptr->Data.ExtendedIrq.Interrupts[0] = 0;
> > > +			memset(&resptr->Data.ExtendedIrq.ResourceSource, 0,
> > > +			    sizeof(ACPI_RESOURCE_SOURCE));
> > >  			link++;
> > >  			i++;
> > >  			break;
> >
> > Hmm...  Very interesting.  Can you please try this, too?
>
> Linux doesn't set the resource source bits up at all when doing
> _SRS, so I'd rather just do that.  I think what I'd prefer is that
> we not use the prs_template, perhaps just save the type of the
> resource and build a new resource object from scratch where the
> resource is zero'd, the appropriate bits are set and then that
> resource is appended to the buffer being built.

"Linux doesn't do it" is wrong if I am reading the spec. correctly, 
i.e., _CRS, _PRS and _SRS must have the same format and size.

Jung-uk Kim