From owner-freebsd-bugs@FreeBSD.ORG  Fri Oct 31 17:10:05 2008
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2880F1065673
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 31 Oct 2008 17:10:05 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 15A128FC1A
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 31 Oct 2008 17:10:05 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id m9VHA4KC046894
	for <freebsd-bugs@freefall.freebsd.org>; Fri, 31 Oct 2008 17:10:04 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id m9VHA40Q046893;
	Fri, 31 Oct 2008 17:10:04 GMT (envelope-from gnats)
Date: Fri, 31 Oct 2008 17:10:04 GMT
Message-Id: <200810311710.m9VHA40Q046893@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Jaakko Heinonen <jh@saunalahti.fi>
Cc: 
Subject: Re: bin/127932: mkdir -p PATH fails if a directory in PATH is on a
	read-only fs
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Jaakko Heinonen <jh@saunalahti.fi>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 31 Oct 2008 17:10:05 -0000

The following reply was made to PR bin/127932; it has been noted by GNATS.

From: Jaakko Heinonen <jh@saunalahti.fi>
To: Till Toenges <tt@kyon.de>
Cc: bug-followup@freebsd.org
Subject: Re: bin/127932: mkdir -p PATH fails if a directory in PATH is on a
	read-only fs
Date: Fri, 31 Oct 2008 19:01:13 +0200

 Hi,
 
 On 2008-10-08, Till Toenges wrote:
 > Treat EROFS like EISDIR and EEXIST.
 > 
 > Patch attached with submission follows:
 > 
 > --- /usr/src/bin/mkdir/mkdir.c	2006-10-10 22:18:20.000000000 +0200
 > +++ /root/mkdir/mkdir.c	2008-10-08 01:44:22.000000000 +0200
 > @@ -177,7 +177,7 @@
 >  		if (last)
 >  			(void)umask(oumask);
 >  		if (mkdir(path, last ? omode : S_IRWXU | S_IRWXG | S_IRWXO) < 0) {
 > -			if (errno == EEXIST || errno == EISDIR) {
 > +			if (errno == EEXIST || errno == EISDIR || errno == EROFS) {
 >  				if (stat(path, &sb) < 0) {
 >  					warn("%s", path);
 >  					retval = 0;
 
 This has patch has a problem. Patched mkdir(1) gives a bogus error
 message if a directory creation fails on read-only file system.
 
 $ mkdir -p foo (unpatched)
 mkdir: foo: Read-only file system
 $ mkdir -p foo (patched)
 mkdir: foo: No such file or directory
 
 The latter error message is very misleading because the real reason for
 the failure is read-only file system.
 
 Maybe save the original error number and if stat(2) fails in EROFS case
 then use it instead of the error from stat(2). Something like this:
 
 %%%
 Index: bin/mkdir/mkdir.c
 ===================================================================
 --- bin/mkdir/mkdir.c	(revision 183921)
 +++ bin/mkdir/mkdir.c	(working copy)
 @@ -140,7 +140,7 @@ build(char *path, mode_t omode)
  {
  	struct stat sb;
  	mode_t numask, oumask;
 -	int first, last, retval;
 +	int first, last, retval, serrno;
  	char *p;
  
  	p = path;
 @@ -177,8 +177,12 @@ build(char *path, mode_t omode)
  		if (last)
  			(void)umask(oumask);
  		if (mkdir(path, last ? omode : S_IRWXU | S_IRWXG | S_IRWXO) < 0) {
 -			if (errno == EEXIST || errno == EISDIR) {
 +			if (errno == EEXIST || errno == EISDIR ||
 +			    errno == EROFS) {
 +				serrno = errno;
  				if (stat(path, &sb) < 0) {
 +					if (serrno == EROFS)
 +						errno = EROFS;
  					warn("%s", path);
  					retval = 0;
  					break;
 %%%
 
 -- 
 Jaakko