From owner-cvs-all Tue Apr 30 16:20:29 2002 Delivered-To: cvs-all@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id D5A8737B404; Tue, 30 Apr 2002 16:20:22 -0700 (PDT) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id JAA11446; Wed, 1 May 2002 09:20:13 +1000 Date: Wed, 1 May 2002 09:21:37 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Warner Losh Cc: cvs-committers@FreeBSD.org, Subject: Re: cvs commit: src/sys/dev/wi wi_hostap.c In-Reply-To: <200204302241.g3UMfab87030@harmony.village.org> Message-ID: <20020501091926.B2902-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, 30 Apr 2002, Warner Losh wrote: > In message <20020501020252.W11154-100000@gamplex.bde.org> Bruce Evans writes: > > : This file also misuses splsoftclock. splsoftclock has different > : semantics in FreeBSD. Using it is at best a hack except in the one > : place where it has the correct semantics (in hardclock() in RELENG_4), > : and even in that place its use is dubious -- it only works right on > : some machines, not including i386's (so it is not used on i386's). > : Drivers should use a device-specific spl to mask softclock interrupts > : (splnet for network drivers). > > OK. I'm not understanding what you are saying here. Should I just > use splimp as well? The spl stuff is underdocumented at the moment. Use splnet instead of NetBSD's splsoftclock and splsoftnet. All spls mask timeouts, and splnet _is_ splsoftnet (NetBSD renamed it for consistency). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message