Date: Tue, 24 Nov 2015 11:51:56 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: marino@freebsd.org Cc: Gerald Pfeifer <gerald@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r402352 - head/lang/gcc Message-ID: <20151124115156.GA3457@FreeBSD.org> In-Reply-To: <5654459E.40100@marino.st> References: <201511241019.tAOAJMTF049917@repo.freebsd.org> <20151124110152.GA78748@FreeBSD.org> <5654459E.40100@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Nov 24, 2015 at 12:10:22PM +0100, John Marino wrote: > On 11/24/2015 12:01 PM, Alexey Dokuchaev wrote: > > On Tue, Nov 24, 2015 at 10:19:22AM +0000, Gerald Pfeifer wrote: > >> Author: gerald > >> URL: https://svnweb.freebsd.org/changeset/ports/402352 > >> > >> [...] > >> @@ -168,5 +168,10 @@ post-stage: > >> fi > >> .endfor > >> cd ${WRKDIR} ; ${SED} -i -e "/PLIST.lib/ r PLIST.lib" ${TMPPLIST} > >> + # This is the canonical GCC port, so add key commands without > >> + # version numbers as part of their names. > > > > Comment is badly indented (will be executed as part of the target recipe). > > Are you sure? I thought that only applies to legacy make, not bmake. Hmm, indeed. But even if bmake is smart enough to skip shell comments, it still looks like part of the recipe, which is not very neat. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151124115156.GA3457>