From owner-svn-src-all@freebsd.org Wed May 30 14:37:48 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A412BF718F5; Wed, 30 May 2018 14:37:48 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from c.mail.sonic.net (c.mail.sonic.net [64.142.111.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 34341862D8; Wed, 30 May 2018 14:37:48 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from comporellon.tachypleus.net (cpe-75-82-218-62.socal.res.rr.com [75.82.218.62]) (authenticated bits=0) by c.mail.sonic.net (8.15.1/8.15.1) with ESMTPSA id w4UER4lp007350 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Wed, 30 May 2018 07:27:04 -0700 Subject: Re: svn commit: r334365 - head/sys/dev/pci To: Peter Grehan , Justin Hibbits , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201805300241.w4U2fmvB033942@repo.freebsd.org> <25bd4319-6d7f-e668-88e4-4c3adbc1e8e9@freebsd.org> From: Nathan Whitehorn Message-ID: <264b6c9f-efa3-13e8-1d41-0cdc8631ec82@freebsd.org> Date: Wed, 30 May 2018 07:27:03 -0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <25bd4319-6d7f-e668-88e4-4c3adbc1e8e9@freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Sonic-CAuth: UmFuZG9tSVY68c4vhh+HeWvzBM1e+W/fFe9bF75e0Bg6DbhyHDYEPMx4KDxESJtgzCmwVrGJsCSrczTht8XRZaY2uwUrHxsNA1vSApdEKLk= X-Sonic-ID: C;+GY+hhVk6BGh5K41UvMdPQ== M;WKGPhhVk6BGh5K41UvMdPQ== X-Spam-Flag: No X-Sonic-Spam-Details: 0.0/5.0 by cerberusd X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 May 2018 14:37:48 -0000 On 05/30/18 02:42, Peter Grehan wrote: >>    PCIe only permits 1 device on an endpoint, so some devices ignore >> the device >>    part of B:D:F probing.  Although ARI likely fixes this, not all >> platforms >>    support ARI completely or correctly, so some devices end up >> showing up 32 >>    times on the bus. > >  I think this might have broken bhyve - a fake PCIe capability is put > on the root port so that guests will use MSI/MSI-x, but otherwise it > looks like parallel PCI. Not exactly spec-compliant, but then neither > is most of the world of PCI/PCIe. > >  It may be worth #ifdef'ing this with powerpc. > > later, > > Peter. > There are a ton of ARM boards that need this too. You can find one-off hacks all through the tree and one of the nice things about this change is that all of those can be consolidated/removed now. If we are going to have some #ifdef and special cases, it would be better to make them for bhyve. -Nathan