From nobody Thu Sep 25 12:41:37 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cXYHk4Hd4z68SCt; Thu, 25 Sep 2025 12:41:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cXYHj5cZ5z42bX; Thu, 25 Sep 2025 12:41:37 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758804097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XIRe8P+ooCPWmt33sxsjjlsJlpnOUfRI+eLloQyRA+Q=; b=dG+Y1aiNKSWsjWQ28MdjfeP3PVQ8Jr4ddzU3f4H+E41r+S6qMbNXtTEgQYo7xRS/374yEr ulgBdnENqMhQDeqP1LsPu9Uzh3RVNtMH2Q1eHQz40tzuQKlZcZUWOX0TV1vnmqLNb0T1Kp lvAW/QV9J1o9yCvyEomqEQpS3R9bAIBwW1UyoJFKRq8NyxmcE6ppbj4Zyr9qWQn/c7rh9d KBWu7o5Ix1WIZNKY2RNqveSa+VaH9Ctn3Bl1ret1wIHaxRBnsTG69HdkuNNomGSAPZLP/F /StUiU9Py3DWLbayb21luVyeCU4Lxa9YTxU84g4J9YgKfbc/pH953Y4wFp4OHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758804097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XIRe8P+ooCPWmt33sxsjjlsJlpnOUfRI+eLloQyRA+Q=; b=OlGuouBLWe6RJsQipOcIQNIXEezcoJmMcrxGGgxr/aIuJHJMjV1PDzGHNfJ2BMEREz+Dnm Fn1FCDbWUsm7DWD11JqKaFIdro3y40GLoORE3bSNDxz8CAeZlExzC+mEnS+ygJh9FrhQjp av/n/XfI65uA7r9bOkYN1uh0sHptXbe5JKS9KRn+KHs1uzB5K6aZ2rmjwknCLf+74OFhGt 4l0/juCazEdtF9C7FkSlo2G1riKTi5O5mpRgqwmekYJsR36e6WlKiqrN1FL6wMxeZ91I/a d7UJQd5VaQyHib+/jOLBPD2AYAdQHmiDad1r3nOvIBVrPfk6paUxvwFLurCmDA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758804097; a=rsa-sha256; cv=none; b=ekI6tX0sAXKf1PBVVa/A10Xjtllshun0Lqas1IyzuLJDNhQGIx4h3N6OUE/P0np9Xxhbyk 4Gc6gZtsJ7+Dk0sQRD8nG22de6xIhtoizRQ2ox7g6qBQl3j4fXOTCQutfjjg9NxC7aFSo3 c/sGHvCHDt80exS8/UPXLL54Z632V8Q1fkhTPTd9ClVi34b7TAZoXT4RnMcEmUiKocmQxB QPur1Ix4Ju+p42nD1er+08XN4mkpyVVZWTxCF05Rfmfk4l8Fje69EmKJWGbJQfJ2E/ydmA gYHsB8ptJovnp7inEigGxGhZiHJQNPDRq9ruFcR/QCN4yxnvjM7dmfKlLit/sw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cXYHj4zWsz1GmV; Thu, 25 Sep 2025 12:41:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58PCfbRo003228; Thu, 25 Sep 2025 12:41:37 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58PCfbvF003218; Thu, 25 Sep 2025 12:41:37 GMT (envelope-from git) Date: Thu, 25 Sep 2025 12:41:37 GMT Message-Id: <202509251241.58PCfbvF003218@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: d3b73a944b11 - main - pfctl: deny "once" flags for match rules List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d3b73a944b11311b8428f30b019802ebe7aeaef8 Auto-Submitted: auto-generated The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=d3b73a944b11311b8428f30b019802ebe7aeaef8 commit d3b73a944b11311b8428f30b019802ebe7aeaef8 Author: Kristof Provost AuthorDate: 2025-08-27 14:00:38 +0000 Commit: Kristof Provost CommitDate: 2025-09-25 12:41:08 +0000 pfctl: deny "once" flags for match rules ok henning Obtained from: OpenBSD, mikeb , 47068a62ee Sponsored by: Rubicon Communications, LLC ("Netgate") --- sbin/pfctl/parse.y | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/sbin/pfctl/parse.y b/sbin/pfctl/parse.y index c35460f5443d..c8c6f6047fa5 100644 --- a/sbin/pfctl/parse.y +++ b/sbin/pfctl/parse.y @@ -2396,8 +2396,14 @@ pfrule : action dir logquick interface route af proto fromto r.quick = $3.quick; r.af = $6; - if ($9.marker & FOM_ONCE) + if ($9.marker & FOM_ONCE) { + if (r.action == PF_MATCH) { + yyerror("can't specify once for " + "match rules"); + YYERROR; + } r.rule_flag |= PFRULE_ONCE; + } if (filteropts_to_rule(&r, &$9)) YYERROR;