From owner-cvs-all Thu Jan 21 21:56:05 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id VAA23384 for cvs-all-outgoing; Thu, 21 Jan 1999 21:56:05 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from opus.cts.cwu.edu (opus.cts.cwu.edu [198.104.92.71]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id VAA23342; Thu, 21 Jan 1999 21:56:01 -0800 (PST) (envelope-from skynyrd@opus.cts.cwu.edu) Received: from localhost (skynyrd@localhost) by opus.cts.cwu.edu (8.9.1/8.9.1) with SMTP id TAA08975; Thu, 21 Jan 1999 19:39:58 -0800 (PST) Date: Thu, 21 Jan 1999 19:39:58 -0800 (PST) From: Chris Timmons To: Satoshi Asami cc: ejc@FreeBSD.ORG, cvs-committers@FreeBSD.ORG Subject: Re: cvs commit: ports/x11-toolkits/tk81/patches patch-ab In-Reply-To: <199901220108.RAA21128@vader.cs.berkeley.edu> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk In the port Makefile for tk80 I had to explicitly set it in the environment: CONFIGURE_ENV= PORTSDIR=${PORTSDIR} TK_LIB_FILE=${TK_LIB_FILE} Then, in patch-aa, patch configure: @@ -2344,7 +2345,7 @@ if test "$ok" = "yes" -a "${SHLIB_SUFFIX}" != ""; then TK_SHARED_BUILD=1 TK_SHLIB_CFLAGS="${SHLIB_CFLAGS}" - TK_LIB_FILE=libtk${TCL_SHARED_LIB_SUFFIX} + TK_LIB_FILE=${TK_LIB_FILE} MAKE_LIB="\${SHLIB_LD} -o \${TK_LIB_FILE} \${OBJS} \$(TK_LD_SEARCH_FLAGS) ${SHLIB_LD_LIBS}" RANLIB=":" else This was VERY ODD; it wasn't necessary to do the environment hack but I couldn't figure out the underlying problem... -Chris > Are you sure this is correct? It still uses a soname of > libtk8.1.so.1. That means that if you link against libtk81.so, the > binary won't be able to find libtk81.so.1 in runtime (since it will be > looking at libtk8.1.so.1). > > Looking at patch-ab (but not the file it's patching), shouldn't you go > about changing TK_LIB_FILE? > > By the way, it fails build in 2.2: > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message