From owner-cvs-all Wed Jul 24 14:49:19 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 165BC37B400; Wed, 24 Jul 2002 14:49:13 -0700 (PDT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 152AC43E75; Wed, 24 Jul 2002 14:49:12 -0700 (PDT) (envelope-from arr@watson.org) Received: from fledge.watson.org (localhost [127.0.0.1]) by fledge.watson.org (8.12.4/8.12.4) with ESMTP id g6OLaYOn090462; Wed, 24 Jul 2002 17:36:34 -0400 (EDT) (envelope-from arr@watson.org) Received: from localhost (arr@localhost) by fledge.watson.org (8.12.4/8.12.4/Submit) with SMTP id g6OLaXsH090459; Wed, 24 Jul 2002 17:36:33 -0400 (EDT) X-Authentication-Warning: fledge.watson.org: arr owned process doing -bs Date: Wed, 24 Jul 2002 17:36:32 -0400 (EDT) From: "Andrew R. Reiter" To: Doug Ambrisko Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/sound/pci csa.c In-Reply-To: <200207242127.g6OLRMNk099651@freefall.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, 24 Jul 2002, Doug Ambrisko wrote: :ambrisko 2002/07/24 14:27:22 PDT : : Modified files: : sys/dev/sound/pci csa.c : Log: : Fake a resume method for this chip via calling detach/attach. This lets : ThinkPads using this chip to have sound after a suspend/resume sequence : without resorting to kldunload/kldload. : : MFC after: 1 week : : Revision Changes Path : 1.24 +10 -1 src/sys/dev/sound/pci/csa.c Has cg@ given up "maintainership" of the sound code? This is not to question your commit, but rather to see if I can go ahead and fix the sound locking code... From when I looked at it lsast, it was fairly broke in terms of how it should be done (ie, WHY DO WE NEED MULTIPLE FUNCTION CALLS JUST TO THEN CALL MTX_LOCK()??????) Thanks, Andrew -- Andrew R. Reiter arr@watson.org arr@FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message