From owner-freebsd-bugs@FreeBSD.ORG Fri Aug 22 21:10:03 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 258191065678 for ; Fri, 22 Aug 2008 21:10:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id ED1BD8FC1D for ; Fri, 22 Aug 2008 21:10:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m7MLA2Ak088087 for ; Fri, 22 Aug 2008 21:10:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m7MLA2I8088086; Fri, 22 Aug 2008 21:10:02 GMT (envelope-from gnats) Resent-Date: Fri, 22 Aug 2008 21:10:02 GMT Resent-Message-Id: <200808222110.m7MLA2I8088086@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Nick Hibma Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2B695106564A for ; Fri, 22 Aug 2008 21:02:27 +0000 (UTC) (envelope-from nick@van-laarhoven.org) Received: from hpsmtp-eml15.kpnxchange.com (hpsmtp-eml15.kpnxchange.com [213.75.38.115]) by mx1.freebsd.org (Postfix) with ESMTP id B6AE38FC15 for ; Fri, 22 Aug 2008 21:02:26 +0000 (UTC) (envelope-from nick@van-laarhoven.org) Received: from cpsmtpi-eml04.kpnxchange.com ([213.75.38.134]) by hpsmtp-eml15.kpnxchange.com with Microsoft SMTPSVC(6.0.3790.1830); Fri, 22 Aug 2008 23:02:24 +0200 Received: from uitsmijter.van-laarhoven.org ([81.207.207.222]) by cpsmtpi-eml04.kpnxchange.com with Microsoft SMTPSVC(6.0.3790.1830); Fri, 22 Aug 2008 23:02:24 +0200 Received: (qmail 94210 invoked by uid 98); 22 Aug 2008 21:02:21 -0000 Received: from 10.66.0.133 (nick@10.66.0.133) by uitsmijter.van-laarhoven.org (envelope-from , uid 82) with qmail-scanner-2.01 (clamdscan: 0.92/5270. f-prot: 4.6.7/3.16.15. spamassassin: 3.2.3. Clear:RC:1(10.66.0.133):. Processed in 0.754519 secs); 22 Aug 2008 21:02:21 -0000 Received: from unknown (HELO van-laarhoven.org) (nick@10.66.0.133) by uitsmijter.van-laarhoven.org with SMTP; 22 Aug 2008 21:02:20 -0000 Received: (nullmailer pid 5431 invoked by uid 1001); Fri, 22 Aug 2008 21:02:20 -0000 Message-Id: <1219438940.453155.5430.nullmailer@van-laarhoven.org> Date: Fri, 22 Aug 2008 23:02:20 +0200 From: Nick Hibma To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: bin/126747: bsd.dep.mk does not remove .depend on cleandepend if CTAGS is not set or set to something other than ctags or gtags. X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Aug 2008 21:10:03 -0000 >Number: 126747 >Category: bin >Synopsis: bsd.dep.mk does not remove .depend on cleandepend if CTAGS is not set or set to something other than ctags or gtags. >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Fri Aug 22 21:10:02 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Nick Hibma >Release: FreeBSD 7.0-STABLE i386 >Organization: >Environment: System: FreeBSD hind.van-laarhoven.org 7.0-STABLE FreeBSD 7.0-STABLE #3: Thu Aug 14 21:10:55 CEST 2008 toor@hind.van-laarhoven.org:/usr/src/sys/i386/compile/HIND i386 >Description: cleandepend in /usr/share/mk/bsd.dep.mk depends on the CTAGS variable in a strange way. It does not remove the .depend file unless CTAGS is set to a value it understands. >How-To-Repeat: make CTAGS=exctags depend make CTAGS=exctags cleandepend make CTAGS=exctags depend Notice how the second time round the depend does not execute any commands. >Fix: Change in /usr/share/mk/bsd.dep.mk .if !target(cleandepend) cleandepend: .if defined(SRCS) .if ${CTAGS:T} == "ctags" rm -f ${DEPENDFILE} tags .elif ${CTAGS:T} == "gtags" rm -f ${DEPENDFILE} GPATH GRTAGS GSYMS GTAGS .if defined(HTML) rm -rf HTML .endif .endif .endif .endif to .if !target(cleandepend) cleandepend: .if defined(SRCS) .if ${CTAGS:T} == "gtags" rm -f ${DEPENDFILE} GPATH GRTAGS GSYMS GTAGS .if defined(HTML) rm -rf HTML .endif .else rm -f ${DEPENDFILE} tags .endif .endif .endif which deletes .depend and the tags file in all cases. >Release-Note: >Audit-Trail: >Unformatted: