From owner-svn-src-head@freebsd.org Thu Apr 16 00:46:26 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 704392C73F9; Thu, 16 Apr 2020 00:46:26 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 492gX22L27z4fBR; Thu, 16 Apr 2020 00:46:26 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 3E7661C08B; Thu, 16 Apr 2020 00:46:26 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qk1-f181.google.com with SMTP id m67so19609182qke.12; Wed, 15 Apr 2020 17:46:26 -0700 (PDT) X-Gm-Message-State: AGi0PuaBtDULiFuNpnM8cgFWG1QA6toxPa+0w7+OhJCpLLF6IZ78aBuT iLpuZM6vfYICKHz6wtXl0m1IjVNGFOdway2l3Ck= X-Google-Smtp-Source: APiQypKmlZLjtbphBiWy0mcp7N72ricIGKFbNvQNl5QBVPzTYZkMba1K8jcrAjSZtJU7AThuZ8/2Dt74FNRu62TpRBk= X-Received: by 2002:a05:620a:1395:: with SMTP id k21mr14034637qki.120.1586997985857; Wed, 15 Apr 2020 17:46:25 -0700 (PDT) MIME-Version: 1.0 References: <202004152021.03FKLU0u090535@repo.freebsd.org> In-Reply-To: <202004152021.03FKLU0u090535@repo.freebsd.org> From: Kyle Evans Date: Wed, 15 Apr 2020 19:46:14 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r359987 - in head/sys: amd64/ia32 amd64/linux32 compat/freebsd32 kern sys To: Brooks Davis Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2020 00:46:26 -0000 On Wed, Apr 15, 2020 at 3:21 PM Brooks Davis wrote: > > Author: brooks > Date: Wed Apr 15 20:21:30 2020 > New Revision: 359987 > URL: https://svnweb.freebsd.org/changeset/base/359987 > > Log: > Make ps_strings in struct image_params into a pointer. > > This is a prepratory commit for D24407. > > Reviewed by: kib > Obtained from: CheriBSD > Sponsored by: DARPA > This seems to have missed just one spot over in i386 machdep bits (reported by CI, masked by earlier-in-the-build breakage): 18:28:51 /usr/src/sys/i386/i386/machdep.c:1174:15: error: incompatible pointer to integer conversion assigning to 'int' from 'void *' [-Werror,-Wint-conversion] 18:28:51 regs->tf_ebx = imgp->ps_strings; 18:28:51 ^ ~~~~~~~~~~~~~~~~ Thanks, Kyle Evans