Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 15 Apr 2020 19:46:14 -0500
From:      Kyle Evans <kevans@freebsd.org>
To:        Brooks Davis <brooks@freebsd.org>
Cc:        src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>,  svn-src-head <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r359987 - in head/sys: amd64/ia32 amd64/linux32 compat/freebsd32 kern sys
Message-ID:  <CACNAnaEWm6E4nsFK_QGwi84zNmWvZgMy8UA-HcQr%2BvPXq3rdgg@mail.gmail.com>
In-Reply-To: <202004152021.03FKLU0u090535@repo.freebsd.org>
References:  <202004152021.03FKLU0u090535@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Apr 15, 2020 at 3:21 PM Brooks Davis <brooks@freebsd.org> wrote:
>
> Author: brooks
> Date: Wed Apr 15 20:21:30 2020
> New Revision: 359987
> URL: https://svnweb.freebsd.org/changeset/base/359987
>
> Log:
>   Make ps_strings in struct image_params into a pointer.
>
>   This is a prepratory commit for D24407.
>
>   Reviewed by:  kib
>   Obtained from:        CheriBSD
>   Sponsored by: DARPA
>

This seems to have missed just one spot over in i386 machdep bits
(reported by CI, masked by earlier-in-the-build breakage):

18:28:51 /usr/src/sys/i386/i386/machdep.c:1174:15: error: incompatible
pointer to integer conversion assigning to 'int' from 'void *'
[-Werror,-Wint-conversion]
18:28:51         regs->tf_ebx = imgp->ps_strings;
18:28:51                      ^ ~~~~~~~~~~~~~~~~

Thanks,

Kyle Evans



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaEWm6E4nsFK_QGwi84zNmWvZgMy8UA-HcQr%2BvPXq3rdgg>