From owner-cvs-all  Sat Dec 11  2:50:17 1999
Delivered-To: cvs-all@freebsd.org
Received: from zippy.cdrom.com (zippy.cdrom.com [204.216.27.228])
	by hub.freebsd.org (Postfix) with ESMTP
	id CFB8514E34; Sat, 11 Dec 1999 02:50:10 -0800 (PST)
	(envelope-from jkh@zippy.cdrom.com)
Received: from zippy.cdrom.com (localhost [127.0.0.1])
	by zippy.cdrom.com (8.9.3/8.9.3) with ESMTP id CAA81215;
	Sat, 11 Dec 1999 02:50:22 -0800 (PST)
	(envelope-from jkh@zippy.cdrom.com)
To: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net>
Cc: jdp@FreeBSD.ORG (John Polstra), cvs-committers@FreeBSD.ORG,
	cvs-all@FreeBSD.ORG, jkh@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/net route.c 
In-reply-to: Your message of "Thu, 09 Dec 1999 14:00:52 PST."
             <199912092200.OAA03662@gndrsh.dnsmgr.net> 
Date: Sat, 11 Dec 1999 02:50:22 -0800
Message-ID: <81212.944909422@zippy.cdrom.com>
From: "Jordan K. Hubbard" <jkh@zippy.cdrom.com>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

I wouldn't disagree.

> > jdp         1999/12/09 09:09:39 PST
> > 
> >   Modified files:
> >     sys/net              route.c 
> >   Log:
> >   Fix a route table leak in rtalloc() and rtalloc_ign().  It is
> >   possible for ro->ro_rt to be non-NULL even though the RTF_UP flag
> >   is cleared.  (Example: a routing daemon or the "route" command
> >   deletes a cloned route in active use by a TCP connection.)  In that
> >   case, the code was clobbering a reference to the routing table
> >   entry without decrementing the entry's reference count.
> >   
> >   The splnet() call probably isn't needed, but I haven't been able
> >   to prove that yet.  It isn't significant from a performance standpoint
> >   since it is executed very rarely.
> >   
> >   Reviewed by:	wollman and others in the freebsd-current mailing list
> >   
> >   Revision  Changes    Path
> >   1.57      +13 -6     src/sys/net/route.c
> 
> John, Jordan, can we get a MFC for this, this leak has heavily effected the
> -stable branch for some time and it would be nice to not have it in 3.4.
> 
> 
> -- 
> Rod Grimes - KD7CAX @ CN85sl - (RWG25)               rgrimes@gndrsh.dnsmgr.ne
t
> 



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message