Date: Sat, 11 Dec 1999 02:50:22 -0800 From: "Jordan K. Hubbard" <jkh@zippy.cdrom.com> To: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> Cc: jdp@FreeBSD.ORG (John Polstra), cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, jkh@FreeBSD.ORG Subject: Re: cvs commit: src/sys/net route.c Message-ID: <81212.944909422@zippy.cdrom.com> In-Reply-To: Your message of "Thu, 09 Dec 1999 14:00:52 PST." <199912092200.OAA03662@gndrsh.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
I wouldn't disagree. > > jdp 1999/12/09 09:09:39 PST > > > > Modified files: > > sys/net route.c > > Log: > > Fix a route table leak in rtalloc() and rtalloc_ign(). It is > > possible for ro->ro_rt to be non-NULL even though the RTF_UP flag > > is cleared. (Example: a routing daemon or the "route" command > > deletes a cloned route in active use by a TCP connection.) In that > > case, the code was clobbering a reference to the routing table > > entry without decrementing the entry's reference count. > > > > The splnet() call probably isn't needed, but I haven't been able > > to prove that yet. It isn't significant from a performance standpoint > > since it is executed very rarely. > > > > Reviewed by: wollman and others in the freebsd-current mailing list > > > > Revision Changes Path > > 1.57 +13 -6 src/sys/net/route.c > > John, Jordan, can we get a MFC for this, this leak has heavily effected the > -stable branch for some time and it would be nice to not have it in 3.4. > > > -- > Rod Grimes - KD7CAX @ CN85sl - (RWG25) rgrimes@gndrsh.dnsmgr.ne t > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?81212.944909422>