From owner-freebsd-current Thu Dec 17 13:41:49 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id NAA20922 for freebsd-current-outgoing; Thu, 17 Dec 1998 13:41:49 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from nlsystems.com (nlsys.demon.co.uk [158.152.125.33]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA20917 for ; Thu, 17 Dec 1998 13:41:46 -0800 (PST) (envelope-from dfr@nlsystems.com) Received: from herring.nlsystems.com (herring.nlsystems.com [10.0.0.2]) by nlsystems.com (8.9.1/8.8.5) with SMTP id VAA64820; Thu, 17 Dec 1998 21:42:46 GMT Date: Thu, 17 Dec 1998 21:42:46 +0000 (GMT) From: Doug Rabson To: Mike Smith cc: Paul van der Zwan , current@FreeBSD.ORG Subject: Re: Weird NFS error using Solaris 7 server In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Thu, 17 Dec 1998, Doug Rabson wrote: > .... One strange effect on a FreeBSD server (with or without this > patch) is that the modtime of testfile1 is set to -1. I'll look into > that later. It turns out that there is a minor problem with ufs_setattr(). The setting of atime and mtime is confused (this appeared in revision 1.91 I think). Index: ufs_vnops.c =================================================================== RCS file: /home/ncvs/src/sys/ufs/ufs/ufs_vnops.c,v retrieving revision 1.101 diff -u -r1.101 ufs_vnops.c --- ufs_vnops.c 1998/12/09 02:06:27 1.101 +++ ufs_vnops.c 1998/12/17 21:41:52 @@ -506,9 +506,9 @@ if (vap->va_mtime.tv_sec != VNOVAL) ip->i_flag |= IN_CHANGE | IN_UPDATE; ufs_itimes(vp); - if (vap->va_mtime.tv_sec != VNOVAL) - ip->i_atime = vap->va_atime.tv_sec; if (vap->va_atime.tv_sec != VNOVAL) + ip->i_atime = vap->va_atime.tv_sec; + if (vap->va_mtime.tv_sec != VNOVAL) ip->i_mtime = vap->va_mtime.tv_sec; error = UFS_UPDATE(vp, (struct timeval *)0, (struct timeval *)0, 0); -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 442 9037 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message