From owner-freebsd-net@FreeBSD.ORG Mon Apr 26 21:18:08 2010 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A65301065670 for ; Mon, 26 Apr 2010 21:18:08 +0000 (UTC) (envelope-from jamesbrandongooch@gmail.com) Received: from mail-pv0-f182.google.com (mail-pv0-f182.google.com [74.125.83.182]) by mx1.freebsd.org (Postfix) with ESMTP id 7515D8FC1B for ; Mon, 26 Apr 2010 21:18:08 +0000 (UTC) Received: by pvc21 with SMTP id 21so556839pvc.13 for ; Mon, 26 Apr 2010 14:18:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=eDbw3pkYcRnBq7ZbhcrVehE+1L6vPZQZU1IIjWzwuxc=; b=Em/WpJ7D0apnoCwtpaPxbpAv0Atk+PUeAzRh0qi3gIheBDH07Zz+tjJQh0dpwhULbz U26BaZkkElDrHah3f3SQFq9Ec1p/xOhgsvdTN5yaOZxH1nkn0Xzjqc4nrpEXEN3t6TcP k7smI4+Y6mCyvHxySh+YT+j9skwI51p3fAx68= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=VUFu+ROVJQ1XVWTgAYLMvcq4cN5tFaRk68eKOdy6kghwbV5LKHh4pSe9EM23X7/TYr rjhhNtw+RV6Qm4LOA9owSelnNa5fN6M4wgYEAtwb48gIj9p55YuMZO9tG1JNSasT7w44 95BKthCU10r/ffkBv4DfEG+WLSnG0GcjEcPAY= MIME-Version: 1.0 Received: by 10.141.213.36 with SMTP id p36mr4678135rvq.5.1272316683155; Mon, 26 Apr 2010 14:18:03 -0700 (PDT) Received: by 10.231.113.36 with HTTP; Mon, 26 Apr 2010 14:18:03 -0700 (PDT) In-Reply-To: References: Date: Mon, 26 Apr 2010 16:18:03 -0500 Message-ID: From: Brandon Gooch To: Jacques Fourie Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-net@freebsd.org Subject: Re: m_copymdata() bug? X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Apr 2010 21:18:08 -0000 On Tue, Apr 13, 2010 at 8:30 AM, Jacques Fourie wrote: > It seems as if the m_copymdata() function defined in uipc_mbuf.c has a > bug. It uses m_apply to copy data from the source mbuf to the target > but in the callback function m_bcopyxxx() the arguments are > interpreted in the wrong order. Swapping the 's' and 't' arguments in > the declaration of m_bcopyxxx() fixes the problem for me. Perhaps you should file a PR with an included patch: http://www.freebsd.org/doc/en_US.ISO8859-1/articles/problem-reports/article.html http://www.freebsd.org/send-pr.html Thanks! -Brandon