From owner-freebsd-current@FreeBSD.ORG  Thu Oct 30 12:47:55 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6BEAB16A4CF
	for <freebsd-current@FreeBSD.ORG>;
	Thu, 30 Oct 2003 12:47:55 -0800 (PST)
Received: from spider.deepcore.dk
	(cpe.atm2-0-53484.0x50a6c9a6.abnxx9.customer.tele.dk [80.166.201.166])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B89AC43F75
	for <freebsd-current@FreeBSD.ORG>;
	Thu, 30 Oct 2003 12:47:53 -0800 (PST)
	(envelope-from sos@spider.deepcore.dk)
Received: from spider.deepcore.dk (localhost [127.0.0.1])
	by spider.deepcore.dk (8.12.10/8.12.10) with ESMTP id h9UKmIJw021301;
	Thu, 30 Oct 2003 21:48:18 +0100 (CET)
	(envelope-from sos@spider.deepcore.dk)
Received: (from sos@localhost)
	by spider.deepcore.dk (8.12.10/8.12.10/Submit) id h9UKmHaB021300;
	Thu, 30 Oct 2003 21:48:17 +0100 (CET)
	(envelope-from sos)
From: Soren Schmidt <sos@spider.deepcore.dk>
Message-Id: <200310302048.h9UKmHaB021300@spider.deepcore.dk>
In-Reply-To: <3FA169C9.5070501@isi.edu>
To: Lars Eggert <larse@ISI.EDU>
Date: Thu, 30 Oct 2003 21:48:17 +0100 (CET)
X-Mailer: ELM [version 2.4ME+ PL99f (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset=ISO-8859-1
X-mail-scanned: by DeepCore Virus & Spam killer v1.3
cc: freebsd-current@FreeBSD.ORG
Subject: Re: ATAng regression: cdcontrol close not working
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Oct 2003 20:47:55 -0000

It seems Lars Eggert wrote:
> > I've already committed a solution that works on all the drives I 
> > could test on (some of which failed before), if this still 
> > fails for you I'd like a more detailed description of what
> > exactly goes wrong...
> 
> I must have missed that commit message, sorry. This is the drive I am 
> having the issues with:
> 
> acd0: CDRW <PHILIPS DVD+RW-D28> at ata1-master UDMA33
> 
> Sending CDIOCCLOSE from a short C snippet shows that the ioctl yields EBUSY.

Hmm, now that a real stupid return code from the drive IMNHO...

Anyhow if you loose the test for error in atapi-cd.c::acd_tray in the
close case, does it work then ? Problem is that the call to read toc
might fail early, but its worth a shot..
 
-Søren