Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 3 Feb 2023 10:12:58 +0100
From:      Mathieu Arnold <mat@freebsd.org>
To:        Muhammad Moinur Rahman <bofh@freebsd.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: 8607332fb826 - main - www/gitlab-pages: Fix bulk build warning
Message-ID:  <20230203091258.5ou4dpzklcp7euqj@aching.in.mat.cc>
In-Reply-To: <202302022304.312N4C2R091641@gitrepo.freebsd.org>
References:  <202302022304.312N4C2R091641@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--snmeiphvvtywapiy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 02, 2023 at 11:04:12PM +0000, Muhammad Moinur Rahman wrote:
> The branch main has been updated by bofh:
>=20
> URL: https://cgit.FreeBSD.org/ports/commit/?id=3D8607332fb8268becd08f7e6c=
fbc853bc76e2cc43
>=20
> commit 8607332fb8268becd08f7e6cfbc853bc76e2cc43
> Author:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
> AuthorDate: 2023-02-02 23:01:36 +0000
> Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
> CommitDate: 2023-02-02 23:01:36 +0000
>=20
>     www/gitlab-pages: Fix bulk build warning
>    =20
>     In the previous commit a duplicate USE_FETCH target was added similar=
 to
>     the one in Mk/Uses/go.mk. However this is possible using a different
>     number and target name compared to what is already predefined as it
>     conflicts.

I fail to see the functional difference between this target and the
existing one in USES=3Dgo, and it feels that now, the fetch is done twice,
once in USES=3Dgo and once here.

Can you try to see if it still works without this target here?

>     Reported by:    bulk build
>     Approved by:    portmgr (just-fix-it)
> ---
>  www/gitlab-pages/Makefile | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>=20
> diff --git a/www/gitlab-pages/Makefile b/www/gitlab-pages/Makefile
> index 9a97306037d6..da241eeec460 100644
> --- a/www/gitlab-pages/Makefile
> +++ b/www/gitlab-pages/Makefile
> @@ -1,5 +1,6 @@
>  PORTNAME=3D	gitlab-pages
>  PORTVERSION=3D	15.8.1
> +PORTREVISION=3D	1
>  DISTVERSIONPREFIX=3D	v
>  CATEGORIES=3D	www
> =20
> @@ -29,8 +30,8 @@ MASTER_SITES+=3D	https://gitlab.com/gitlab-org/gitlab-p=
ages/-/raw/v${DISTVERSION}/
>  DISTFILES+=3D	go.mod
>  DIST_SUBDIR=3D	go/${PKGORIGIN:S,/,_,g}/${DISTNAME}
>  EXTRACT_ONLY+=3D	${DISTFILES:N*.mod\:*:N*.mod:C/:.*//}
> -_USES_fetch+=3D	800:go-post-fetch
> -go-post-fetch:
> +_USES_fetch+=3D	900:go-post-fetch-gitlab
> +go-post-fetch-gitlab:
>  	@${ECHO_MSG} "=3D=3D=3D> Fetching ${PORTNAME} dependencies";
>  	@(cd ${DISTDIR}/${DIST_SUBDIR}; \
>  		[ -e go.mod ] || ${RLN} ${GO_MODFILE} go.mod; \
>=20

--=20
Mathieu Arnold

--snmeiphvvtywapiy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmPc0BpfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1
NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d
Qb4adwv9GNJMeev4JFackCwT2s4JhKCqAws79vJI+1Jiq2FeYrgH6Om+uORrAEPB
tsPhrDlKDWC49zX/p0abTqnT0kicuSOgjRIyZrs4zwealTXlvOeWGnTg05Mt4Zw0
52FmEy0Ct36Lp2c27Eqlw4fEXHrAQrn4+F+34wYyDI6v643NhQ6edDdk/XLf2CiS
E9kTK5iEOx2NJmTrOzGigTVWY1AwCAnfuH8GkkNVpm0/h90fn1Xij16vEnCw9IFX
skxcG9QpV6RdTRc+y6OD6sGEo0yShgOCRKrWTfbqKToHi5WJKXulZoYE8CWyF4ME
/gdkZiYQAk94fn/YGLjnmQRiw6g5TW61yTFM1C8lQ2SnyaztCFVWb5cU9rIl2fzC
ySo7gsGblW7aOcZMm20CrXpHjAWh8YQIP6etQouq2qz8b6NHAxICa4rKG5XHtkzH
ejKf72wxDLs6VxbJJ+Pon25IQUKO/J4IBcNjtWgJHbuZFFn/Rr5NP8y0JtcSk1Q1
YAQnP0bo
=FBDM
-----END PGP SIGNATURE-----

--snmeiphvvtywapiy--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20230203091258.5ou4dpzklcp7euqj>