From owner-svn-src-projects@FreeBSD.ORG Sat Nov 15 02:35:11 2014 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1DFA3423; Sat, 15 Nov 2014 02:35:11 +0000 (UTC) Received: from mail105.syd.optusnet.com.au (mail105.syd.optusnet.com.au [211.29.132.249]) by mx1.freebsd.org (Postfix) with ESMTP id CF2923F0; Sat, 15 Nov 2014 02:35:10 +0000 (UTC) Received: from c122-106-147-133.carlnfd1.nsw.optusnet.com.au (c122-106-147-133.carlnfd1.nsw.optusnet.com.au [122.106.147.133]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id BE10A10423C8; Sat, 15 Nov 2014 13:35:07 +1100 (AEDT) Date: Sat, 15 Nov 2014 13:35:06 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Ian Lepore Subject: Re: svn commit: r274513 - in projects/sendfile/sys: kern sys In-Reply-To: <1415991101.4781.110.camel@revolution.hippie.lan> Message-ID: <20141115125642.J1288@besplex.bde.org> References: <201411141555.sAEFtvur007240@svn.freebsd.org> <20141114182504.GE1031@FreeBSD.org> <1415991101.4781.110.camel@revolution.hippie.lan> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.1 cv=BdjhjNd2 c=1 sm=1 tr=0 a=7NqvjVvQucbO2RlWB8PEog==:117 a=PO7r1zJSAAAA:8 a=kj9zAlcOel0A:10 a=JzwRw_2MAAAA:8 a=6I5d2MoRAAAA:8 a=1XWaLZrsAAAA:8 a=DYe5F3tMMLQD5HBOBsYA:9 a=CjuIK1q_8ugA:10 Cc: svn-src-projects@freebsd.org, Gleb Smirnoff , Sergey Kandaurov , src-committers@freebsd.org X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Nov 2014 02:35:11 -0000 On Fri, 14 Nov 2014, Ian Lepore wrote: > On Fri, 2014-11-14 at 21:25 +0300, Gleb Smirnoff wrote: >> On Fri, Nov 14, 2014 at 10:23:51PM +0400, Sergey Kandaurov wrote: >> S> On 14 November 2014 18:55, Gleb Smirnoff wrote: >> ... >> S> > #define M_NOTREADY M_PROTO1 /* m_data not populated yet */ >> S> > #define M_BLOCKED M_PROTO2 /* M_NOTREADY in front of m */ >> S> > #define M_NOTAVAIL (M_NOTREADY | M_BLOCKED) >> S> > +#define M_SBCUTTED M_PROTO3 /* mbuf was sbcutted out */ >> S> >> S> Seriously? There's no such word in (modern) English :). >> >> I also had such feeling, but translate.google.com convinced me wrong :) > > Cutted is not proper modern English. It is listed by some dictionaries > as dialectical and nonstandard. I've been speaking English for a bit > less than 55 years and I've never once heard anyone say cutted, or seen > it in writing. That's "cutted". Doesn't everyone say "sbcutted"? :-) It is still not useful to echo an identifier's name in a comment when describing what the identifer means. You should also consider using an English word in the identifer. That is done for "BLOCKED". "block" is a less irregular verb than "cut", so it can express delicate tenses more clearly. However, this is not usually done for "block". Blocking flags used to be consistently spelled without the "ED". Now in , there is 1 spelled with an "ED" and about 18 without. Many of the "BLOCK" flags are initially for the action of creating a block, and "BLOCKED" is a wrong tense for that. But when a "BLOCK" flag is tested and found to be set, it means that something is blocked, and "BLOCKED" has a better tense for that. More complicated tenses might be more correct but are usually avoided in identifiers; EWOULDBLOCK is an exception. Bruce