From owner-freebsd-stable@FreeBSD.ORG Sat Jul 5 13:08:05 2014 Return-Path: Delivered-To: stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 096AE8CC; Sat, 5 Jul 2014 13:08:05 +0000 (UTC) Received: from tensor.andric.com (unknown [IPv6:2001:7b8:3a7:1:2d0:b7ff:fea0:8c26]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "tensor.andric.com", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id B50CE281C; Sat, 5 Jul 2014 13:08:04 +0000 (UTC) Received: from coleburn.home.andric.com (coleburn.home.andric.com [192.168.0.15]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 168725C44; Sat, 5 Jul 2014 15:07:51 +0200 (CEST) Content-Type: multipart/signed; boundary="Apple-Mail=_BFB754AE-3DB6-4CC1-A413-D49D8B2ACC46"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [HEADS-UP] Problem with clang in 9-stable [was: r268244 (stable/9) seems to break "sysctl hw.ncpu"] From: Dimitry Andric In-Reply-To: <909248A4-1B7C-4836-ADAA-F81A70A8AC3C@theravensnest.org> Date: Sat, 5 Jul 2014 15:07:50 +0200 Message-Id: References: <20140704123901.GR6056@albert.catwhisker.org> <53B6E218.5070009@selasky.org> <20140704174705.GS6056@albert.catwhisker.org> <53B6EDD1.8030506@selasky.org> <20140704181831.GV6056@albert.catwhisker.org> <909248A4-1B7C-4836-ADAA-F81A70A8AC3C@theravensnest.org> To: David Chisnall X-Mailer: Apple Mail (2.1878.6) Cc: Hans Petter Selasky , stable@freebsd.org, "current@freebsd.org" X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Jul 2014 13:08:05 -0000 --Apple-Mail=_BFB754AE-3DB6-4CC1-A413-D49D8B2ACC46 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 05 Jul 2014, at 14:49, David Chisnall = wrote: > On 4 Jul 2014, at 19:18, David Wolfskill wrote: >=20 >> clang -O2 -pipe -std=3Dgnu99 -Qunused-arguments -fstack-protector = -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter = -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith = -Wno-uninitialized -Wno-pointer-sign -Wno-empty-body = -Wno-string-plus-int -Wno-unused-const-variable = -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality = -Wno-unused-function -Wno-enum-conversion -o sysctl sysctl.o=20 >=20 > This compile line is turning off a lot of warnings. In particular, = -Wno-uninitialized and -Wno-parentheses-equality are likely to hide = warnings that refer to real errors. Interestingly, -Wno-uninitialized has been in bsd.sys.mk since r76861, and the accompanying comment ("XXX Delete -Wuninitialized by default for now -- the compiler doesn't always get it right") has never been changed. :-) It is probably time to re-enable that warning after 13 years, at least. I'm not so sure about -Wno-parentheses-equality, because that might give quite a few false positives, especially in old, contributed code. -Dimitry --Apple-Mail=_BFB754AE-3DB6-4CC1-A413-D49D8B2ACC46 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iEYEARECAAYFAlO3+KYACgkQsF6jCi4glqOwnACbBHvEd5jjCn21OaTqw4Yt2xnb kW4AmwVuMdRnWZaarzsr4FmKaT2RwSQ/ =T8v3 -----END PGP SIGNATURE----- --Apple-Mail=_BFB754AE-3DB6-4CC1-A413-D49D8B2ACC46--