From owner-svn-src-all@FreeBSD.ORG Thu Nov 29 02:34:27 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id CF8F5C0D; Thu, 29 Nov 2012 02:34:27 +0000 (UTC) (envelope-from stas@FreeBSD.org) Received: from mx0.deglitch.com (backbone.deglitch.com [78.110.53.255]) by mx1.freebsd.org (Postfix) with ESMTP id 1070C8FC15; Thu, 29 Nov 2012 02:34:27 +0000 (UTC) Received: from freebsd (unknown [72.5.114.2]) by mx0.deglitch.com (Postfix) with ESMTPA id 9E3BF8FC2B; Thu, 29 Nov 2012 06:34:23 +0400 (MSK) Date: Wed, 28 Nov 2012 18:34:22 -0800 From: Stanislav Sedov To: Eitan Adler Subject: Re: svn commit: r243554 - in head/usr.sbin/pkg_install: add create delete info lib updating version Message-Id: <20121128183422.714562856f27371c95d2a84e@FreeBSD.org> In-Reply-To: References: <201211260511.qAQ5B7DQ002346@svn.freebsd.org> <20121128170032.730be5fab68dba2a09aaa14e@FreeBSD.org> Organization: The FreeBSD Project X-Mailer: carrier-pigeon Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Stanislav Sedov , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2012 02:34:28 -0000 On Wed, 28 Nov 2012 21:03:58 -0500 Eitan Adler mentioned: > On 28 November 2012 20:00, Stanislav Sedov wrote: > > On Mon, 26 Nov 2012 05:11:07 +0000 (UTC) > > Eitan Adler mentioned: > > > >> Author: eadler > >> Date: Mon Nov 26 05:11:07 2012 > >> New Revision: 243554 > >> URL: http://svnweb.freebsd.org/changeset/base/243554 > >> > >> Log: > >> Provide an option to users to shoot themselves in the foot. > >> > > > > This should probably be a default behavior. It's not good when all these > > warnings pop up everywhere just because local.sqlite file is present. > > Making the foot shooting behavior default defeats the point. > If local.sqlite exists it almost certainly means that you don't want > to run the old pkg_ tools. > For the few correct uses an opt-out option is provided. > Well, it's not entirely true. I did end up with local.sqlite because I stepped on the landmine of portmgr-pkg becoming the default for some reason. So I did end up with half of my packages being in the pkgng sqlite database, and half in standard /var/db/pkg. I had to convert them back to standard format by hand, but I still have the sqlite database just in case. I guess if you really want to prevent a foot-shooting, you should add a message to pkgng sayng in all caps e.g. "You are running experimental package manager and there's no migration plan from pkgng to old pkg exists." and maybe ask for confirmation. I don't really see how this message being in pkg_ tools helps to prevent a possible foot-shooting at all. At very least, it makes sense to make it conditional on WITH_PKGNG, so this code does not end up compiled in if PKGNG is disabled in src.conf. -- Stanislav Sedov ST4096-RIPE () ascii ribbon campaign - against html e-mail /\ www.asciiribbon.org - against proprietary attachments