From owner-cvs-all@FreeBSD.ORG  Wed Mar 30 23:08:47 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2A8D516A4CE; Wed, 30 Mar 2005 23:08:47 +0000 (GMT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 0C47F43D3F; Wed, 30 Mar 2005 23:08:47 +0000 (GMT)
	(envelope-from mux@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j2UN8kOK074296;
	Wed, 30 Mar 2005 23:08:46 GMT
	(envelope-from mux@repoman.freebsd.org)
Received: (from mux@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j2UN8kNT074295;
	Wed, 30 Mar 2005 23:08:46 GMT
	(envelope-from mux)
Message-Id: <200503302308.j2UN8kNT074295@repoman.freebsd.org>
From: Maxime Henrion <mux@FreeBSD.org>
Date: Wed, 30 Mar 2005 23:08:46 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: RELENG_5
Subject: cvs commit: src/sys/dev/ixgb if_ixgb.c if_ixgb.h if_ixgb_osdep.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Mar 2005 23:08:47 -0000

mux         2005-03-30 23:08:46 UTC

  FreeBSD src repository

  Modified files:        (Branch: RELENG_5)
    sys/dev/ixgb         if_ixgb.c if_ixgb.h if_ixgb_osdep.h 
  Log:
  MFC if_ixgb.c r1.6 to r1.7, if_ixgb.h r1.4 and if_ixgb_osdep.h r1.3:
    Fix a bunch of bugs I came accross when looking at the ixgb(4) driver,
    some of which are rather serious:
    - Use the device sysctl tree instead of rolling our own.
    - Don't create a bus_dmamap_t to pass to bus_dmamem_alloc(), it is
      bus_dmamem_alloc() that creates it itself.  The DMA map created
      by the driver was overwritten and its memory was leaked.
    - Fix resource handling bugs in the error path of ixgb_dma_alloc().
    - Don't use vtophys() to get the base address of the TX and RX rings
      when busdma already gave us the correct address to use!
    - Remove now useless includes and the alpha_XXX_dmamap() hack.
    - Don't initialize if_output to ether_output(), ether_ifattach() does
      it for us already.
    - Add proper module dependencies on ether and pci.
  
  Tested by:      Paul Willmann willmann at rice dot edu
  Approved by:    re@ (kensmith)
  
  Revision  Changes    Path
  1.3.2.1   +9 -32     src/sys/dev/ixgb/if_ixgb.c
  1.2.4.1   +0 -7      src/sys/dev/ixgb/if_ixgb.h
  1.1.4.1   +0 -2      src/sys/dev/ixgb/if_ixgb_osdep.h