From owner-freebsd-perl@FreeBSD.ORG Wed Jan 21 11:14:03 2004 Return-Path: Delivered-To: freebsd-perl@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8473916A4CE; Wed, 21 Jan 2004 11:14:03 -0800 (PST) Received: from mail.3wgraphics.net (mail.3wgraphics.net [194.87.91.161]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5DF5043D5F; Wed, 21 Jan 2004 11:13:42 -0800 (PST) (envelope-from skv@protey.ru) Received: from [192.168.0.1] (helo=protey.ru) by mail.3wgraphics.net with esmtp (Exim 4.24; FreeBSD) id 1AjNpT-000IpN-J1; Wed, 21 Jan 2004 22:15:55 +0300 Message-ID: <400ECFEB.40809@protey.ru> Date: Wed, 21 Jan 2004 22:15:55 +0300 From: Sergey Skvortsov Organization: 3W Graphics User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5) Gecko/20031007 X-Accept-Language: en,ru MIME-Version: 1.0 To: Mathieu Arnold References: <400D4EE6.8010003@FreeBSD.org> <447910631.1074622626@andromede.reaumur.absolight.net> <400E4909.5020309@FreeBSD.org> <5310937.1074682561@pouet.in.mat.cc> <400E9591.8040109@protey.ru> <528419787.1074703138@andromede.reaumur.absolight.net> In-Reply-To: <528419787.1074703138@andromede.reaumur.absolight.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Spam-Report: Spam detection software, running on the system "freebsd.3wgraphics.net", hasmessageblock similar future email. If you have any questions, see the administrator of that system for details. Content preview: Mathieu Arnold wrote: > |> And you should define| defaultperl ports ALL_TARGETS="all test" they'll know > that it's not "all" but "build". [...] Content analysis details: (0.0 points, 5.0 required) pts rule name description -------------------------------------------------- cc: perl@FreeBSD.org Subject: Re: requst for review: PR/61621 X-BeenThere: freebsd-perl@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: maintainer of a number of perl-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jan 2004 19:14:03 -0000 Mathieu Arnold wrote: > |> And you should define ALL_TARGET?= build so that it has a resonable > |> default I guess. > | > | Empty target also works. > > It would tell people what the default target should be in case they want to > do as they do for regular perl ports ALL_TARGETS="all test" they'll know > that it's not "all" but "build". Agree. > |> And, you'll have to account for M::B build process, it should use > |> PERL_MODBUILD=yes, but it should not depend on M::B, or it'll kinda loop > |> :) > | > | p5-Module-Build should use usual "PERL_CONFIGURE" and redefine > | do-(build|install). > | > | Special check for portname 'p5-Module-Build' in bsd.port.mk is overkill > | and must be avoided. > > That would lead to code dupplication, I don't believe it's good, but well, > if you think it's better this way :) There will be no checking for portname on _every_ port. -- Sergey Skvortsov mailto: skv@protey.ru