Date: Mon, 22 Oct 2007 09:40:02 GMT From: Ruslan Ermilov <ru@FreeBSD.org> To: freebsd-ports@FreeBSD.org Subject: Re: bin/11420 [nanobsd] Build failure on RELENG_6 Message-ID: <200710220940.l9M9e2kk075393@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/11420; it has been noted by GNATS.
From: Ruslan Ermilov <ru@freebsd.org>
To: "M. Warner Losh" <imp@bsdimp.com>, freebsd-embedded@freebsd.org,
bug-followup@freebsd.org
Cc:
Subject: Re: bin/11420 [nanobsd] Build failure on RELENG_6
Date: Mon, 22 Oct 2007 13:29:27 +0400
On Sat, Oct 20, 2007 at 10:03:13PM +0400, Ruslan Ermilov wrote:
> On Tue, Oct 16, 2007 at 12:37:54AM +0200, Henrik Brix Andersen wrote:
> > On Mon, Jul 02, 2007 at 07:47:21AM -0600, M. Warner Losh wrote:
> > > In message: <20070702084757.GA8274@tirith.brixandersen.dk>
> > > Henrik Brix Andersen <henrik@brixandersen.dk> writes:
> > > : On Sun, Jul 01, 2007 at 07:01:35PM -0600, M. Warner Losh wrote:
> > > : > In message: <20070701233235.GA875@tirith.brixandersen.dk>
> > > : > Henrik Brix Andersen <henrik@brixandersen.dk> writes:
> > > : ...
> > > : > : [1]: http://www.freebsd.org/cgi/query-pr.cgi?pr=114200
> > > : >
> > > : > This patch is incorrect.
> > > : >
> > > : > +.if !defined(NO_INSTALLLIB)
> > > : >
> > > : > should be
> > > : >
> > > : > +.if ${MK_INSTALLIB} != "no"
> > > :
> > > : Oh - thanks for catching this. I guess the same change should be done
> > > : in lib/ncurses/ncurses/Makefile, then?
> > >
> > > I belive so. I've CC'd ru@ to make sure.
> >
> > Any updates on this? It would be nice to have this install problem fixed
> > before 7.0-RELEASE.
> >
> NO_INSTALLLIB wasn't converted to a new syntax and is
> still spelled NO_INSTALLLIB in makefiles:
>
> : bsd.lib.mk:.if defined(LIB) && !empty(LIB) && !defined(NO_INSTALLLIB)
>
Ah, I now see that you converted it to a new option syntax
in bsd.own.mk. Your patch is now committed to CVS HEAD,
except I had to apply one more fixup in libpam/modules/,
so that we don't start to install libpam_unix.a.
Cheers,
--
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200710220940.l9M9e2kk075393>