Skip site navigation (1)Skip section navigation (2) 
Date:      Tue, 26 Jul 2022 20:10:00 GMT
From:      Dimitry Andric <dim@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: ed1d5f95a599 - main - Adjust function definitions in ufs_dirhash.c to avoid clang 15 warnings
Message-ID:  <202207262010.26QKA0HP076287@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
The branch main has been updated by dim:

URL: https://cgit.FreeBSD.org/src/commit/?id=ed1d5f95a599635e2af4a78ce96bfcdf8a3b7a47

commit ed1d5f95a599635e2af4a78ce96bfcdf8a3b7a47
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2022-07-26 19:32:20 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2022-07-26 19:32:55 +0000

    Adjust function definitions in ufs_dirhash.c to avoid clang 15 warnings
    
    With clang 15, the following -Werror warnings are produced:
    
        sys/ufs/ufs/ufs_dirhash.c:1303:16: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
        ufsdirhash_init()
                       ^
                        void
        sys/ufs/ufs/ufs_dirhash.c:1319:18: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
        ufsdirhash_uninit()
                         ^
                          void
    
    This is because ufsdirhash_init() and ufsdirhash_uninit() are declared
    with (void) argument lists, but defined with empty argument lists. Make
    the definitions match the declarations.
    
    MFC after:      3 days
---
 sys/ufs/ufs/ufs_dirhash.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sys/ufs/ufs/ufs_dirhash.c b/sys/ufs/ufs/ufs_dirhash.c
index e3b516b8fc8a..955ddf7fc8bb 100644
--- a/sys/ufs/ufs/ufs_dirhash.c
+++ b/sys/ufs/ufs/ufs_dirhash.c
@@ -1300,7 +1300,7 @@ ufsdirhash_set_reclaimpercent(SYSCTL_HANDLER_ARGS)
 }
 
 void
-ufsdirhash_init()
+ufsdirhash_init(void)
 {
 	ufs_dirhashmaxmem = lmax(roundup(hibufspace / 64, PAGE_SIZE),
 	    2 * 1024 * 1024);
@@ -1316,7 +1316,7 @@ ufsdirhash_init()
 }
 
 void
-ufsdirhash_uninit()
+ufsdirhash_uninit(void)
 {
 	KASSERT(TAILQ_EMPTY(&ufsdirhash_list), ("ufsdirhash_uninit"));
 	uma_zdestroy(ufsdirhash_zone);

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202207262010.26QKA0HP076287>